[llvm-branch-commits] [llvm] ea387e2 - RuntimeLibcalls: Move divrem attributes to TableGen (#240730)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Nov 11 01:51:49 PST 2026


Author: Matt Arsenault
Date: 2026-11-11T02:53:59Z
New Revision: ea387e22062aee84c264e14f7896696e0ff7e6fe

URL: https://github.com/llvm/llvm-project/commit/ea387e22062aee84c264e14f7896696e0ff7e6fe
DIFF: https://github.com/llvm/llvm-project/commit/ea387e22062aee84c264e14f7896696e0ff7e6fe.diff

LOG: RuntimeLibcalls: Move divrem attributes to TableGen (#240730)

Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>

Added: 
    

Modified: 
    llvm/include/llvm/IR/RuntimeLibcalls.td
    llvm/include/llvm/IR/RuntimeLibcallsImpl.td
    llvm/lib/IR/RuntimeLibcalls.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/IR/RuntimeLibcalls.td b/llvm/include/llvm/IR/RuntimeLibcalls.td
index b3f844a159389..c4a5e154715cb 100644
--- a/llvm/include/llvm/IR/RuntimeLibcalls.td
+++ b/llvm/include/llvm/IR/RuntimeLibcalls.td
@@ -281,6 +281,8 @@ class DivRemPairImpl<RuntimeLibcall P, string Name = NAME>
   defvar IntTy = P.ReturnType;
   let ReturnType = !cast<FuncArgType>(!cast<string>(IntTy) # "Pair");
   let ArgumentTypes = [IntTy, IntTy];
+  let FnAttrs = MathFnAttrs;
+  let Memory = NoMemory;
 }
 
 foreach IntTy = [TypeSuffix<"I32", Int32>, TypeSuffix<"I64", Int64>] in {

diff  --git a/llvm/include/llvm/IR/RuntimeLibcallsImpl.td b/llvm/include/llvm/IR/RuntimeLibcallsImpl.td
index 3ecfbc989fb27..03346b17fece4 100644
--- a/llvm/include/llvm/IR/RuntimeLibcallsImpl.td
+++ b/llvm/include/llvm/IR/RuntimeLibcallsImpl.td
@@ -158,6 +158,7 @@ class MemoryEffects<ModRefInfo mr = ModRef> {
 }
 
 def UnknownMemory : MemoryEffects;
+def NoMemory : MemoryEffects<NoModRef>;
 def ArgMemWriteOnly : MemoryEffects<NoModRef> { let ArgMem = Mod; }
 def ErrnoMemWriteOnly : MemoryEffects<NoModRef> { let ErrnoMem = Mod; }
 

diff  --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp
index 5d39f1ca9d28c..95d3909af8102 100644
--- a/llvm/lib/IR/RuntimeLibcalls.cpp
+++ b/llvm/lib/IR/RuntimeLibcalls.cpp
@@ -590,27 +590,6 @@ RuntimeLibcallsInfo::getFunctionTy(LLVMContext &Ctx, const Triple &TT,
 
     return {FunctionType::get(RetTy, {ScalarTy}, false), Attrs};
   }
-  case RTLIB::impl___aeabi_idivmod:
-  case RTLIB::impl___aeabi_uidivmod:
-  case RTLIB::impl___aeabi_ldivmod:
-  case RTLIB::impl___aeabi_uldivmod:
-  case RTLIB::impl___rt_sdiv:
-  case RTLIB::impl___rt_udiv:
-  case RTLIB::impl___rt_sdiv64:
-  case RTLIB::impl___rt_udiv64:
-  case RTLIB::impl___divmodqi4:
-  case RTLIB::impl___udivmodqi4:
-  case RTLIB::impl___divmodhi4:
-  case RTLIB::impl___udivmodhi4:
-  case RTLIB::impl_avr___divmodsi4:
-  case RTLIB::impl_avr___udivmodsi4: {
-    auto [FuncTy, Attrs] = getDefaultFunctionTy(Ctx, TT, DL, LibcallImpl);
-    AttrBuilder FuncAttrBuilder(Ctx);
-    for (Attribute::AttrKind Attr : CommonFnAttrs)
-      FuncAttrBuilder.addAttribute(Attr);
-    FuncAttrBuilder.addMemoryAttr(MemoryEffects::none());
-    return {FuncTy, Attrs.addFnAttributes(Ctx, FuncAttrBuilder)};
-  }
   default:
     break;
   }


        


More information about the llvm-branch-commits mailing list