[llvm-branch-commits] [libc] [llvm] [libc] Use a syscall wrapper for getppid (PR #240780)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Tue Nov 10 02:46:47 PST 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Connector Switch (c8ef)
<details>
<summary>Changes</summary>
This PR move getppid behind the centralized syscall wrappers, following libc/docs/dev/syscall_wrapper_refactor.md.
---
Full diff: https://github.com/llvm/llvm-project/pull/240780.diff
5 Files Affected:
- (modified) libc/src/__support/OSUtil/linux/syscall_wrappers/CMakeLists.txt (+12)
- (added) libc/src/__support/OSUtil/linux/syscall_wrappers/getppid.h (+31)
- (modified) libc/src/unistd/linux/CMakeLists.txt (+4-4)
- (modified) libc/src/unistd/linux/getppid.cpp (+8-7)
- (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (+16-1)
``````````diff
diff --git a/libc/src/__support/OSUtil/linux/syscall_wrappers/CMakeLists.txt b/libc/src/__support/OSUtil/linux/syscall_wrappers/CMakeLists.txt
index c77f571f817c3..8685253f2081b 100644
--- a/libc/src/__support/OSUtil/linux/syscall_wrappers/CMakeLists.txt
+++ b/libc/src/__support/OSUtil/linux/syscall_wrappers/CMakeLists.txt
@@ -38,6 +38,18 @@ add_header_library(
libc.include.sys_syscall
)
+add_header_library(
+ getppid
+ HDRS
+ getppid.h
+ DEPENDS
+ libc.hdr.types.pid_t
+ libc.include.sys_syscall
+ libc.src.__support.OSUtil.osutil
+ libc.src.__support.common
+ libc.src.__support.macros.config
+)
+
add_header_library(
getuid
HDRS
diff --git a/libc/src/__support/OSUtil/linux/syscall_wrappers/getppid.h b/libc/src/__support/OSUtil/linux/syscall_wrappers/getppid.h
new file mode 100644
index 0000000000000..0a1f5e266b886
--- /dev/null
+++ b/libc/src/__support/OSUtil/linux/syscall_wrappers/getppid.h
@@ -0,0 +1,31 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+///
+/// \file
+/// Syscall wrapper for getppid.
+///
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC___SUPPORT_OSUTIL_SYSCALL_WRAPPERS_GETPPID_H
+#define LLVM_LIBC_SRC___SUPPORT_OSUTIL_SYSCALL_WRAPPERS_GETPPID_H
+
+#include "hdr/types/pid_t.h"
+#include "src/__support/OSUtil/linux/syscall.h" // syscall_impl
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+#include <sys/syscall.h> // For syscall numbers
+
+namespace LIBC_NAMESPACE_DECL {
+namespace linux_syscalls {
+
+LIBC_INLINE pid_t getppid() { return syscall_impl<pid_t>(SYS_getppid); }
+
+} // namespace linux_syscalls
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC___SUPPORT_OSUTIL_SYSCALL_WRAPPERS_GETPPID_H
diff --git a/libc/src/unistd/linux/CMakeLists.txt b/libc/src/unistd/linux/CMakeLists.txt
index b1ef64940fab9..064ea546e0187 100644
--- a/libc/src/unistd/linux/CMakeLists.txt
+++ b/libc/src/unistd/linux/CMakeLists.txt
@@ -517,10 +517,10 @@ add_entrypoint_object(
../getppid.h
DEPENDS
libc.hdr.types.pid_t
- libc.hdr.fcntl_macros
- libc.include.unistd
- libc.include.sys_syscall
- libc.src.__support.OSUtil.osutil
+ libc.hdr.unistd_macros
+ libc.src.__support.OSUtil.linux.syscall_wrappers.getppid
+ libc.src.__support.common
+ libc.src.__support.macros.config
)
add_entrypoint_object(
diff --git a/libc/src/unistd/linux/getppid.cpp b/libc/src/unistd/linux/getppid.cpp
index c55329daa9f9d..61d89407c6f89 100644
--- a/libc/src/unistd/linux/getppid.cpp
+++ b/libc/src/unistd/linux/getppid.cpp
@@ -1,23 +1,24 @@
-//===-- Linux implementation of getppid -----------------------------------===//
+//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
+///
+/// \file
+/// Linux implementation of getppid.
+///
+//===----------------------------------------------------------------------===//
#include "src/unistd/getppid.h"
-#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
+#include "src/__support/OSUtil/linux/syscall_wrappers/getppid.h"
#include "src/__support/common.h"
#include "src/__support/macros/config.h"
-#include <sys/syscall.h> // For syscall numbers.
-
namespace LIBC_NAMESPACE_DECL {
-LLVM_LIBC_FUNCTION(pid_t, getppid, ()) {
- return LIBC_NAMESPACE::syscall_impl<pid_t>(SYS_getppid);
-}
+LLVM_LIBC_FUNCTION(pid_t, getppid, ()) { return linux_syscalls::getppid(); }
} // namespace LIBC_NAMESPACE_DECL
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 45b3ec8fd1f5a..689ae5d486f01 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -3371,6 +3371,21 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_osutil_linux_syscall_wrappers_getppid",
+ hdrs = ["src/__support/OSUtil/linux/syscall_wrappers/getppid.h"],
+ target_compatible_with = select({
+ "@platforms//os:linux": [],
+ "//conditions:default": ["@platforms//:incompatible"],
+ }),
+ deps = [
+ ":__support_common",
+ ":__support_macros_config",
+ ":__support_osutil_syscall",
+ ":types_pid_t",
+ ],
+)
+
libc_support_library(
name = "__support_osutil_linux_syscall_wrappers_getuid",
hdrs = ["src/__support/OSUtil/linux/syscall_wrappers/getuid.h"],
@@ -18779,7 +18794,7 @@ libc_function(
deps = [
":__support_common",
":__support_macros_config",
- ":__support_osutil_syscall",
+ ":__support_osutil_linux_syscall_wrappers_getppid",
":hdr_unistd_macros",
":types_pid_t",
],
``````````
</details>
https://github.com/llvm/llvm-project/pull/240780
More information about the llvm-branch-commits
mailing list