[llvm-branch-commits] [lldb] [lldb][test] Build PDB test inferiors with column info (PR #238604)

Charles Zablit via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Nov 3 15:56:54 PST 2026


https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/238604

Clang emits columns into DWARF line tables by default but leaves them out of CodeView unless -gcolumn-info is passed, so pdb test inferiors had no columns: frame info printed foo.cpp:3 where tests expect foo.cpp:3:, and breakpoints on lines with several statements picked different locations than with DWARF.

This patch passes -gcolumn-info for MAKE_PDB builds.

Fixes TestBreakOnCPP11Initializers, TestStepThroughTrampoline and TestStructuredBinding with PDB debug info.


---

<sub>Stack created with <a href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub>

>From ab3aa25394e8fe0254d59bf2ce8fbf310fe50120 Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Mon, 28 Sep 2026 13:14:41 +0100
Subject: [PATCH] [lldb][test] Build PDB test inferiors with column info

---
 lldb/packages/Python/lldbsuite/test/make/Makefile.rules         | 2 +-
 .../cpp/break-on-initializers/TestBreakOnCPP11Initializers.py   | 1 -
 .../cpp/step-through-trampoline/TestStepThroughTrampoline.py    | 1 -
 .../API/lang/cpp/structured-binding/TestStructuredBinding.py    | 1 -
 4 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
index aaf1da3ece8d6c..832b91c0db7f0f 100644
--- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
+++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -255,7 +255,7 @@ ifeq ($(CC_TYPE), clang)
 endif
 
 ifeq "$(MAKE_PDB)" "YES"
-	DEBUG_INFO_FLAG ?= -g -gcodeview
+	DEBUG_INFO_FLAG ?= -g -gcodeview -gcolumn-info
 endif
 
 # If the OS is Windows, we need to pass -gdwarf to clang, otherwise it will build
diff --git a/lldb/test/API/lang/cpp/break-on-initializers/TestBreakOnCPP11Initializers.py b/lldb/test/API/lang/cpp/break-on-initializers/TestBreakOnCPP11Initializers.py
index dc45d611e7f26d..995fa166ed8092 100644
--- a/lldb/test/API/lang/cpp/break-on-initializers/TestBreakOnCPP11Initializers.py
+++ b/lldb/test/API/lang/cpp/break-on-initializers/TestBreakOnCPP11Initializers.py
@@ -14,7 +14,6 @@
 
 
 class TestCase(TestBase):
-    @expectedFailureAll(debug_info=["pdb"], bugnumber="llvm.org/pr149498")
     def test_breakpoints_on_initializers(self):
         """Show we can set breakpoints on initializers appearing both before
         and after the constructor body, and hit them."""
diff --git a/lldb/test/API/lang/cpp/step-through-trampoline/TestStepThroughTrampoline.py b/lldb/test/API/lang/cpp/step-through-trampoline/TestStepThroughTrampoline.py
index 2fb08e5de0b24b..732c3660b6bfda 100644
--- a/lldb/test/API/lang/cpp/step-through-trampoline/TestStepThroughTrampoline.py
+++ b/lldb/test/API/lang/cpp/step-through-trampoline/TestStepThroughTrampoline.py
@@ -6,7 +6,6 @@
 
 @skipIfTargetDoesNotSupportSharedLibraries()
 class StepThroughTrampoline(TestBase):
-    @expectedFailureAll(debug_info=["pdb"], bugnumber="llvm.org/pr149498")
     def test(self):
         self.build()
         (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
diff --git a/lldb/test/API/lang/cpp/structured-binding/TestStructuredBinding.py b/lldb/test/API/lang/cpp/structured-binding/TestStructuredBinding.py
index 92cb1a4908a033..882c91d1ce8c85 100644
--- a/lldb/test/API/lang/cpp/structured-binding/TestStructuredBinding.py
+++ b/lldb/test/API/lang/cpp/structured-binding/TestStructuredBinding.py
@@ -7,7 +7,6 @@
 class TestStructuredBinding(TestBase):
     @skipIf(oslist=["linux"], archs=["arm$"])
     @skipIf(compiler="clang", compiler_version=["<", "14.0"])
-    @expectedFailureAll(debug_info=["pdb"], bugnumber="llvm.org/pr149498")
     def test(self):
         self.build()
         lldbutil.run_to_source_breakpoint(



More information about the llvm-branch-commits mailing list