[llvm-branch-commits] [llvm] 3a1e8fc - Revert "[APFloat] Add exp functions for single and double using exp/expf impl…"
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed May 13 06:24:33 PDT 2026
Author: Mehdi Amini
Date: 2026-05-13T15:24:28+02:00
New Revision: 3a1e8fc9796e2e28489918798661aa04b640e457
URL: https://github.com/llvm/llvm-project/commit/3a1e8fc9796e2e28489918798661aa04b640e457
DIFF: https://github.com/llvm/llvm-project/commit/3a1e8fc9796e2e28489918798661aa04b640e457.diff
LOG: Revert "[APFloat] Add exp functions for single and double using exp/expf impl…"
This reverts commit 2b2a63819f9f26d661bad5c269a03077d22ff6b4.
Added:
Modified:
llvm/CMakeLists.txt
llvm/include/llvm/ADT/APFloat.h
llvm/lib/Support/APFloat.cpp
llvm/lib/Support/CMakeLists.txt
llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
llvm/unittests/ADT/APFloatTest.cpp
Removed:
################################################################################
diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index 4509fbaba1d25..6001928f92e37 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -700,10 +700,6 @@ endif()
set(LLVM_ENABLE_Z3_SOLVER_DEFAULT "${Z3_FOUND}")
-include(FindLibcCommonUtils)
-if(NOT TARGET llvm-libc-common-utilities)
- message(FATAL_ERROR "LLVM libc is not found at ${libc_path}.")
-endif()
if( LLVM_TARGETS_TO_BUILD STREQUAL "all" )
set( LLVM_TARGETS_TO_BUILD ${LLVM_ALL_TARGETS} )
diff --git a/llvm/include/llvm/ADT/APFloat.h b/llvm/include/llvm/ADT/APFloat.h
index 07e509baa5f1c..4e5a40d241d36 100644
--- a/llvm/include/llvm/ADT/APFloat.h
+++ b/llvm/include/llvm/ADT/APFloat.h
@@ -1760,10 +1760,6 @@ inline APFloat maximumnum(const APFloat &A, const APFloat &B) {
return A < B ? B : A;
}
-/// Implement IEEE 754-2019 exp functions
-LLVM_READONLY
-APFloat exp(const APFloat &X, RoundingMode RM = APFloat::rmNearestTiesToEven);
-
inline raw_ostream &operator<<(raw_ostream &OS, const APFloat &V) {
V.print(OS);
return OS;
diff --git a/llvm/lib/Support/APFloat.cpp b/llvm/lib/Support/APFloat.cpp
index ee3e0fee5b4bf..013a7cc2d9941 100644
--- a/llvm/lib/Support/APFloat.cpp
+++ b/llvm/lib/Support/APFloat.cpp
@@ -29,19 +29,6 @@
#include <cstring>
#include <limits.h>
-/// Shared headers from LLVM libc
-/// Make sure to add ${LLVM_SOURCE_DIR}/../libc to include directories.
-///
-/// Notes: So far it looks like APFloat does not check errnos or floating-point
-/// exceptions after calling the math functions, so we will configure LLVM libc
-/// math functions to skip setting errnos and floating-point exceptions
-/// explicitly. We also put them in a separate namespace so that the symbols
-/// do not clash with other libc math builds just in case.
-#define LIBC_NAMESPACE __llvm_libc_apfloat
-#define LIBC_MATH (LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)
-
-#include "shared/math.h"
-
#define APFLOAT_DISPATCH_ON_SEMANTICS(METHOD_CALL) \
do { \
if (usesLayout<IEEEFloat>(getSemantics())) \
@@ -6093,24 +6080,6 @@ APFloat::Storage &APFloat::Storage::operator=(APFloat::Storage &&RHS) {
return *this;
}
-// TODO: Support other rounding modes when LLVM libc math implement static
-// roundings.
-APFloat exp(const APFloat &X, RoundingMode rounding_mode) {
- if (rounding_mode == APFloatBase::rmNearestTiesToEven) {
- if (APFloat::SemanticsToEnum(X.getSemantics()) ==
- APFloatBase::S_IEEEsingle) {
- float result = LIBC_NAMESPACE::shared::expf(X.convertToFloat());
- return APFloat(result);
- }
- if (APFloat::SemanticsToEnum(X.getSemantics()) ==
- APFloatBase::S_IEEEdouble) {
- double result = LIBC_NAMESPACE::shared::exp(X.convertToDouble());
- return APFloat(result);
- }
- }
- llvm_unreachable("Unexpected semantics");
-}
-
} // namespace llvm
#undef APFLOAT_DISPATCH_ON_SEMANTICS
diff --git a/llvm/lib/Support/CMakeLists.txt b/llvm/lib/Support/CMakeLists.txt
index c3f5961b6584d..100cfb567c348 100644
--- a/llvm/lib/Support/CMakeLists.txt
+++ b/llvm/lib/Support/CMakeLists.txt
@@ -399,12 +399,7 @@ endif()
target_include_directories(LLVMSupport
PRIVATE
${LLVM_THIRD_PARTY_DIR}/siphash/include
- ${LLVM_SOURCE_DIR}/../libc
)
-if(NOT MSVC)
- target_compile_options(LLVMSupport PRIVATE "-Wno-c99-extensions") # _Complex warnings.
-endif()
-
# SupportLSP depends on Support and therefore must be included afterwards.
add_subdirectory(LSP)
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp b/llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
index 6a41ae7cca4bb..ccc310c2eee2d 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
@@ -1869,7 +1869,7 @@ bool AMDGPULibCalls::evaluateScalarMathFunc(const FuncInfo &FInfo,
return true;
case AMDGPULibFunc::EI_EXP:
- Res0 = APFloat{std::exp(opr0)};
+ Res0 = APFloat{exp(opr0)};
return true;
case AMDGPULibFunc::EI_EXP2:
diff --git a/llvm/unittests/ADT/APFloatTest.cpp b/llvm/unittests/ADT/APFloatTest.cpp
index b25932cd1d94b..b14afa5895ea3 100644
--- a/llvm/unittests/ADT/APFloatTest.cpp
+++ b/llvm/unittests/ADT/APFloatTest.cpp
@@ -10228,62 +10228,4 @@ TEST(APFloatTest, DecimalStringPreservesInexactStatus) {
EXPECT_EQ(F.bitcastToAPInt(), Expected.bitcastToAPInt());
}
-TEST(APFloatTest, expf) {
- // exp(+-0) = 1.
- EXPECT_EQ(1.0f, llvm::exp(APFloat(0.0f)).convertToFloat());
- EXPECT_EQ(1.0f, llvm::exp(APFloat(-0.0f)).convertToFloat());
- // exp(+Inf) = +Inf.
- EXPECT_EQ(std::numeric_limits<float>::infinity(),
- llvm::exp(APFloat::getInf(APFloat::IEEEsingle(), false))
- .convertToFloat());
- // exp(-Inf) = 0.
- EXPECT_EQ(
- 0.0f,
- llvm::exp(APFloat::getInf(APFloat::IEEEsingle(), true)).convertToFloat());
- // exp(NaN) = NaN.
- EXPECT_TRUE(llvm::exp(APFloat::getNaN(APFloat::IEEEsingle())).isNaN());
- // exp(1)
- EXPECT_EQ(0x1.5bf0a8p1f, llvm::exp(APFloat(1.0f)).convertToFloat());
- // exp(float max)
- EXPECT_EQ(std::numeric_limits<float>::infinity(),
- llvm::exp(APFloat::getLargest(APFloat::IEEEsingle(), false))
- .convertToFloat());
- // exp(min_denormal)
- EXPECT_EQ(1.0f, llvm::exp(APFloat::getSmallest(APFloat::IEEEsingle(), false))
- .convertToFloat());
- // exp(-1)
- EXPECT_EQ(0x1.78b564p-2f, llvm::exp(APFloat(-1.0f)).convertToFloat());
- // exp(-90)
- EXPECT_EQ(0x1.1d85p-130f, llvm::exp(APFloat(-90.0f)).convertToFloat());
-}
-
-TEST(APFloatTest, exp) {
- // exp(+-0) = 1.
- EXPECT_EQ(1.0, llvm::exp(APFloat(0.0)).convertToDouble());
- EXPECT_EQ(1.0, llvm::exp(APFloat(-0.0)).convertToDouble());
- // exp(+Inf) = +Inf.
- EXPECT_EQ(std::numeric_limits<double>::infinity(),
- llvm::exp(APFloat::getInf(APFloat::IEEEdouble(), false))
- .convertToDouble());
- // exp(-Inf) = 0.
- EXPECT_EQ(0.0, llvm::exp(APFloat::getInf(APFloat::IEEEdouble(), true))
- .convertToDouble());
- // exp(NaN) = NaN.
- EXPECT_TRUE(llvm::exp(APFloat::getNaN(APFloat::IEEEdouble())).isNaN());
- // exp(1)
- EXPECT_EQ(0x1.5bf0a8b145769p1, llvm::exp(APFloat(1.0)).convertToDouble());
- // exp(float max)
- EXPECT_EQ(std::numeric_limits<double>::infinity(),
- llvm::exp(APFloat::getLargest(APFloat::IEEEdouble(), false))
- .convertToDouble());
- // exp(min_denormal)
- EXPECT_EQ(1.0, llvm::exp(APFloat::getSmallest(APFloat::IEEEdouble(), false))
- .convertToDouble());
- // exp(-1)
- EXPECT_EQ(0x1.78b56362cef38p-2, llvm::exp(APFloat(-1.0)).convertToDouble());
- // exp(-710)
- EXPECT_EQ(0x1.9c017e9459e18p-1025,
- llvm::exp(APFloat(-710.0)).convertToDouble());
-}
-
} // namespace
More information about the llvm-branch-commits
mailing list