[llvm-branch-commits] [clang] [LifetimeSafety] Track per-field origins for record types (PR #195603)
Zhijie Wang via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed May 6 00:00:53 PDT 2026
aeft wrote:
@Xazax-hun Thanks for the suggestion!
> Thanks a lot! I did not do a full review yet because before we spend too much time iterating on this, could you do some benchmarks to see if this have any performance costs?
Sure. I will try llvm-compile-time-tracker.
> Also it would be nice to know how big these trees can grow.
I see. I will report the results (e.g., compile LLVM).
> Are there cases where we compare the depth of two trees? Should we do full shape comparison in those cases?
Yes. One case here is `FactsGenerator::flow`, and I only compare length for now. This is because the tree shape can be different in some cases (e.g., test`derived_to_base_upcast`),
https://github.com/llvm/llvm-project/pull/195603
More information about the llvm-branch-commits
mailing list