[llvm-branch-commits] [clang] [llvm] Continuation of fexec-charset (PR #169803)

[Sergei Barannikov via llvm-branch-commits]

================
@@ -8120,7 +7838,13 @@ bool CheckFormatHandler::HandleInvalidConversionSpecifier(
     keepGoing = false;
   }
 
-  StringRef Specifier(csStart, csLen);
+  // The csStart points to a character that has already been converted to the
+  // exec charset, so we have to reverse the conversion to allow diagnostic
+  // message to match an expected value when using -verify option,
+  std::string RS(csStart, csLen);
----------------
s-barannikov wrote:

Should be StringRef

https://github.com/llvm/llvm-project/pull/169803