[llvm-branch-commits] [VectorCombine] Fix miscompile caused by collisions in foldShuffleToIdentity (PR #188668)

[David Green via llvm-branch-commits]

https://github.com/davemgreen commented:

Hi - this is what the Uses is meant to fix, but if there are multiple unsimplified shuffles it looks like it can still have multiple uses that are both identity and splat. This sounds like it should work but is quite expensive to keep. The original would re-calculate if the value was a splat or identity. Could we change it to store a `pair<Value *FrontV, Value *From>`, that stores where the splat / identity is from? I can provide a patch if that would be more useful.

https://github.com/llvm/llvm-project/pull/188668