[llvm-branch-commits] [clang] [clang] Backport: use canonical arguments for checking function template constraints (PR #186930)

[Erich Keane via llvm-branch-commits]

https://github.com/erichkeane approved this pull request.

Test fail is:
```
2026-03-17T01:33:41.3718175Z FAIL: Clang :: SemaTemplate/concepts-recursive-inst.cpp (17626 of 23664)
2026-03-17T01:33:41.3719373Z ******************** TEST 'Clang :: SemaTemplate/concepts-recursive-inst.cpp' FAILED ********************
2026-03-17T01:33:41.3720126Z Exit Code: 1
2026-03-17T01:33:41.3720305Z 
2026-03-17T01:33:41.3720439Z Command Output (stdout):
2026-03-17T01:33:41.3720786Z --
2026-03-17T01:33:41.3721062Z # RUN: at line 1
2026-03-17T01:33:41.3723375Z /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/22/include -nostdsysteminc -std=c++20 -verify /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaTemplate/concepts-recursive-inst.cpp
2026-03-17T01:33:41.3728243Z # executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/22/include -nostdsysteminc -std=c++20 -verify /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaTemplate/concepts-recursive-inst.cpp
2026-03-17T01:33:41.3730838Z # .---command stderr------------
2026-03-17T01:33:41.3731479Z # | error: 'expected-note' diagnostics expected but not seen: 
2026-03-17T01:33:41.3734089Z # |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaTemplate/concepts-recursive-inst.cpp Line 96 (directive at /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaTemplate/concepts-recursive-inst.cpp:102): while checking the satisfaction of concept 'Numeric<Deferred>' requested here
2026-03-17T01:33:41.3736958Z # | error: 'expected-note' diagnostics seen but not expected: 
2026-03-17T01:33:41.3738755Z # |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaTemplate/concepts-recursive-inst.cpp Line 96: while checking the satisfaction of concept 'Numeric<GH50891::Deferred>' requested here
2026-03-17T01:33:41.3740298Z # | 2 errors generated.
2026-03-17T01:33:41.3740644Z # `-----------------------------
2026-03-17T01:33:41.3741730Z # error: command failed with exit status: 1
2026-03-17T01:33:41.3742393Z 

```


Else, LGTM.

https://github.com/llvm/llvm-project/pull/186930