[llvm-branch-commits] [clang] [Clang] define memory scopes as a builtin enum (PR #185408)

[Joseph Huber via llvm-branch-commits]

jhuber6 wrote:

I'm not a huge fan of this, the initial motivation for this was to have versions of the GNU/LLVM standard atomic builtins that exposed synchronization scopes. Adding special checks that the normal GNU atomics don't have is breaking that expectation. Honestly, checking these values is an improvement overall but there's a lot of historical precedent for these functions.

In my opinion, HIP atomics should just be deprecated, any use of them should emit a warning. The OpenCL atomics are dictated by a standard and should be kept separate.

https://github.com/llvm/llvm-project/pull/185408