[llvm-branch-commits] [clang] release/22.x: [Clang] Check the underlying type dependency in concept checking guards (PR #184079)

[via llvm-branch-commits]

================
@@ -185,12 +185,13 @@ enum class TemplateSubstitutionKind : char {
       return !(*this)(Depth, Index).isNull();
     }
 
-    bool isAnyArgInstantiationDependent() const {
+    bool isAnyArgInstantiationDependent(const ASTContext &C) const {
       for (ArgumentListLevel ListLevel : TemplateArgumentLists)
         for (const TemplateArgument &TA : ListLevel.Args)
           // There might be null template arguments representing unused template
           // parameter mappings in an MLTAL during concept checking.
-          if (!TA.isNull() && TA.isInstantiationDependent())
+          if (!TA.isNull() &&
+              C.getCanonicalTemplateArgument(TA).isInstantiationDependent())
----------------
dyung wrote:

Does your comment mean this fix is not complete? Should I hold off on considering this for merging into the release branch?

https://github.com/llvm/llvm-project/pull/184079