[llvm-branch-commits] [flang] [flang][CodeGen] Replace fir.select* FIR-to-LLVM patterns with stubs that emit conversion errors (PR #212978)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Jul 30 02:53:37 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- flang/lib/Optimizer/CodeGen/CodeGen.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/lib/Optimizer/CodeGen/CodeGen.cpp b/flang/lib/Optimizer/CodeGen/CodeGen.cpp
index 4da07ace5..fc71e4691 100644
--- a/flang/lib/Optimizer/CodeGen/CodeGen.cpp
+++ b/flang/lib/Optimizer/CodeGen/CodeGen.cpp
@@ -3982,16 +3982,15 @@ template <typename OP>
 struct SelectShouldHaveBeenConvertedStub : public fir::FIROpConversion<OP> {
   using fir::FIROpConversion<OP>::FIROpConversion;
 
-  llvm::LogicalResult
-  matchAndRewrite(OP op, typename OP::Adaptor /*adaptor*/,
-                  mlir::ConversionPatternRewriter & /*rewriter*/) const override {
+  llvm::LogicalResult matchAndRewrite(
+      OP op, typename OP::Adaptor /*adaptor*/,
+      mlir::ConversionPatternRewriter & /*rewriter*/) const override {
     op.emitOpError("should have already been converted");
     return mlir::failure();
   }
 };
 
-using SelectOpConversion =
-    SelectShouldHaveBeenConvertedStub<fir::SelectOp>;
+using SelectOpConversion = SelectShouldHaveBeenConvertedStub<fir::SelectOp>;
 using SelectCaseOpConversion =
     SelectShouldHaveBeenConvertedStub<fir::SelectCaseOp>;
 using SelectRankOpConversion =

``````````

</details>


https://github.com/llvm/llvm-project/pull/212978


More information about the llvm-branch-commits mailing list