[llvm-branch-commits] [clang] a36edf6 - [Clang][Interpreter] Don't pass -fPIC on MSVC (#210507)
Douglas Yung via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed Jul 22 06:43:02 PDT 2026
Author: aokblast
Date: 2026-07-22T13:42:45Z
New Revision: a36edf659ef8e168a3e1196cfb7df77522a12b36
URL: https://github.com/llvm/llvm-project/commit/a36edf659ef8e168a3e1196cfb7df77522a12b36
DIFF: https://github.com/llvm/llvm-project/commit/a36edf659ef8e168a3e1196cfb7df77522a12b36.diff
LOG: [Clang][Interpreter] Don't pass -fPIC on MSVC (#210507)
(cherry picked from commit 617e4f54e503b54b08445a086d95a80aa72a58d0)
Added:
Modified:
clang/lib/Interpreter/Interpreter.cpp
Removed:
################################################################################
diff --git a/clang/lib/Interpreter/Interpreter.cpp b/clang/lib/Interpreter/Interpreter.cpp
index 933a68b50db41..0536fdcd548a2 100644
--- a/clang/lib/Interpreter/Interpreter.cpp
+++ b/clang/lib/Interpreter/Interpreter.cpp
@@ -53,6 +53,7 @@
#include "llvm/Support/VirtualFileSystem.h"
#include "llvm/Support/raw_ostream.h"
#include "llvm/TargetParser/Host.h"
+#include "llvm/TargetParser/Triple.h"
#include "llvm/Transforms/Utils/Cloning.h" // for CloneModule
#define DEBUG_TYPE "clang-repl"
@@ -228,8 +229,13 @@ IncrementalCompilerBuilder::create(std::string TT,
// host symbol may be out of range when the JIT memory is mapped more than
// 2GB away (as on FreeBSD), breaking tests such as
// Interpreter/simple-exception.cpp. Insert before user arguments so it can
- // still be overridden.
- ClangArgv.insert(ClangArgv.begin() + 1, "-fPIC");
+ // still be overridden. On Windows (excluding Cygwin/MinGW) an explicit
+ // -fPIC is an unsupported driver option that would drop non-x86_64 targets
+ // to PIC level 0; PIC is already the forced default there where relevant,
+ // so don't inject it.
+ llvm::Triple TargetTriple(TT);
+ if (!TargetTriple.isOSWindows() || TargetTriple.isOSCygMing())
+ ClangArgv.insert(ClangArgv.begin() + 1, "-fPIC");
// Prepending -c to force the driver to do something if no action was
// specified. By prepending we allow users to override the default
More information about the llvm-branch-commits
mailing list