[llvm-branch-commits] [clang] [llvm] clang: Use TargetID parsing from AMDGPUTargetParser (PR #209845)

[Yaxun Liu via llvm-branch-commits]

================
@@ -1537,8 +1524,17 @@ CheckHeterogeneousArchive(StringRef ArchiveName,
     if (CodeObjectFileError)
       return CodeObjectFileError;
 
-    auto &&ConflictingArchs = clang::getConflictTargetIDCombination(BundleIds);
-    if (ConflictingArchs) {
+    // A single bundle may contain several triples. Pair each target ID with its
+    // own triple; the conflict check groups by resolved processor, which is
+    // spelling-independent.
+    llvm::SmallVector<clang::TargetIDEntry> Entries;
----------------
yxsamliu wrote:

Could we add a test for the archive path changed here? Existing tests cover normal driver target-ID parsing and some bundler conflicts, but this code builds `TargetIDEntry` values from bundle IDs read inside `CheckHeterogeneousArchive`. A small archive test with conflicting target IDs, e.g. `gfx906` and `gfx906:xnack+`, would cover this path directly.

https://github.com/llvm/llvm-project/pull/209845