[llvm-branch-commits] [clang] [CIR] Implement MemorySpaceAttrInterface for Lang and Target specific AS attributes (PR #179073)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sat Jan 31 14:34:43 PST 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h clang/include/clang/CIR/Dialect/IR/CIRTypes.h clang/lib/CIR/CodeGen/Address.h clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp clang/lib/CIR/CodeGen/CIRGenExpr.cpp clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp clang/lib/CIR/CodeGen/CIRGenTypeCache.h clang/lib/CIR/CodeGen/TargetInfo.cpp clang/lib/CIR/CodeGen/TargetInfo.h clang/lib/CIR/Dialect/IR/CIRTypes.cpp clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h b/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h
index de32aa227..345507d34 100644
--- a/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h
+++ b/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h
@@ -153,8 +153,8 @@ public:
     return cir::PointerType::get(ty);
   }
 
-
-  cir::PointerType getPointerTo(mlir::Type ty, mlir::ptr::MemorySpaceAttrInterface as) {
+  cir::PointerType getPointerTo(mlir::Type ty,
+                                mlir::ptr::MemorySpaceAttrInterface as) {
     if (!as)
       return cir::PointerType::get(ty);
     return cir::PointerType::get(ty, as);
diff --git a/clang/include/clang/CIR/Dialect/IR/CIRTypes.h b/clang/include/clang/CIR/Dialect/IR/CIRTypes.h
index ff0abfd01..eee4140ba 100644
--- a/clang/include/clang/CIR/Dialect/IR/CIRTypes.h
+++ b/clang/include/clang/CIR/Dialect/IR/CIRTypes.h
@@ -52,7 +52,8 @@ bool isMatchingAddressSpace(mlir::MLIRContext &ctx,
                             mlir::ptr::MemorySpaceAttrInterface cirAS,
                             clang::LangAS as);
 
-/// Convert an AST LangAS to the appropriate CIR address space attribute interface.
+/// Convert an AST LangAS to the appropriate CIR address space attribute
+/// interface.
 mlir::ptr::MemorySpaceAttrInterface
 toCIRAddressSpaceAttr(mlir::MLIRContext *ctx, clang::LangAS langAS);
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/179073


More information about the llvm-branch-commits mailing list