[llvm-branch-commits] [flang] [mlir] [Flang][MLIR][OpenMP] Add distinct var_ptr_ptr_type to omp.map.info operations (PR #177302)

[Pranav Bhandarkar via llvm-branch-commits]

================
@@ -909,8 +917,9 @@ class MapInfoFinalizationPass
         builder.loadIfRef(op->getLoc(), baseAddr.getVarPtrPtr());
     mlir::omp::MapInfoOp newBaseAddrMapOp = mlir::omp::MapInfoOp::create(
         builder, op->getLoc(), loadBaseAddr.getType(), loadBaseAddr,
-        baseAddr.getVarTypeAttr(), baseAddr.getMapTypeAttr(),
-        baseAddr.getMapCaptureTypeAttr(), mlir::Value{}, members, membersAttr,
+        baseAddr.getVarPtrPtrTypeAttr(), baseAddr.getMapTypeAttr(),
----------------
bhandarkar-pranav wrote:

Should this be `builder.getVarPtrTypeAttr()`? But, at this point, i think a top level descriptor is being removed. So, if the descriptor hierarchy is being flattened, i think the pointee becomes the main type. So this might even be intentional. In either case a comment would be in good order here.

https://github.com/llvm/llvm-project/pull/177302