[llvm-branch-commits] [llvm] [NFCI][AMDGPU] Use `GET_SUBTARGETINFO_MACRO` in `GCNSubtarget.h` (PR #177402)
Shilei Tian via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Jan 22 09:03:34 PST 2026
================
@@ -759,13 +500,11 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo,
// FLAT GLOBAL VOffset is signed
bool hasSignedGVSOffset() const { return HasGFX1250Insts; }
- bool enableSIScheduler() const { return EnableSIScheduler; }
-
bool loadStoreOptEnabled() const { return EnableLoadStoreOpt; }
- bool hasUserSGPRInit16Bug() const {
- return HasUserSGPRInit16Bug && isWave32();
- }
+ // bool hasUserSGPRInit16Bug() const {
----------------
shiltian wrote:
I need some suggestions for this function and the one below, `hasLDSMisalignedBug`. I commented them out here because they conflict with the getter defined by TableGen. Apparently, it is not enough to just use the getter, since these functions have extra checks. What should we name these two? I’m running out of ideas.
https://github.com/llvm/llvm-project/pull/177402
More information about the llvm-branch-commits
mailing list