[llvm-branch-commits] [llvm] [NFC][LowerMemIntrinsics] Consistent parameter name comments in function calls (PR #176751)
Fabian Ritter via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Jan 19 05:19:29 PST 2026
https://github.com/ritter-x2a created https://github.com/llvm/llvm-project/pull/176751
The `/*ParamName=*/foo` syntax is prescribed by the coding standards:
https://llvm.org/docs/CodingStandards.html#comment-formatting
>From 594619016506b53e6b5b3197eb9e6f9915cf8daa Mon Sep 17 00:00:00 2001
From: Fabian Ritter <fabian.ritter at amd.com>
Date: Mon, 19 Jan 2026 07:57:22 -0500
Subject: [PATCH] [NFC][LowerMemIntrinsics] Consistent parameter name comments
in function calls
The `/*ParamName=*/foo` syntax is prescribed by the coding standards:
https://llvm.org/docs/CodingStandards.html#comment-formatting
---
.../Transforms/Utils/LowerMemIntrinsics.cpp | 106 +++++++++---------
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp b/llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp
index d040b9bf875bd..088c8b1a74377 100644
--- a/llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp
+++ b/llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp
@@ -1243,32 +1243,32 @@ void llvm::expandMemCpyAsLoop(MemCpyInst *Memcpy,
auto TripCount = getAverageMemOpLoopTripCount(*Memcpy);
if (ConstantInt *CI = dyn_cast<ConstantInt>(Memcpy->getLength())) {
createMemCpyLoopKnownSize(
- /* InsertBefore */ Memcpy,
- /* SrcAddr */ Memcpy->getRawSource(),
- /* DstAddr */ Memcpy->getRawDest(),
- /* CopyLen */ CI,
- /* SrcAlign */ Memcpy->getSourceAlign().valueOrOne(),
- /* DestAlign */ Memcpy->getDestAlign().valueOrOne(),
- /* SrcIsVolatile */ Memcpy->isVolatile(),
- /* DstIsVolatile */ Memcpy->isVolatile(),
- /* CanOverlap */ CanOverlap,
- /* TargetTransformInfo */ TTI,
- /* AtomicElementSize */ std::nullopt,
- /* AverageTripCount */ TripCount);
+ /*InsertBefore=*/Memcpy,
+ /*SrcAddr=*/Memcpy->getRawSource(),
+ /*DstAddr=*/Memcpy->getRawDest(),
+ /*CopyLen=*/CI,
+ /*SrcAlign=*/Memcpy->getSourceAlign().valueOrOne(),
+ /*DstAlign=*/Memcpy->getDestAlign().valueOrOne(),
+ /*SrcIsVolatile=*/Memcpy->isVolatile(),
+ /*DstIsVolatile=*/Memcpy->isVolatile(),
+ /*CanOverlap=*/CanOverlap,
+ /*TTI=*/TTI,
+ /*AtomicElementSize=*/std::nullopt,
+ /*AverageTripCount=*/TripCount);
} else {
createMemCpyLoopUnknownSize(
- /* InsertBefore */ Memcpy,
- /* SrcAddr */ Memcpy->getRawSource(),
- /* DstAddr */ Memcpy->getRawDest(),
- /* CopyLen */ Memcpy->getLength(),
- /* SrcAlign */ Memcpy->getSourceAlign().valueOrOne(),
- /* DestAlign */ Memcpy->getDestAlign().valueOrOne(),
- /* SrcIsVolatile */ Memcpy->isVolatile(),
- /* DstIsVolatile */ Memcpy->isVolatile(),
- /* CanOverlap */ CanOverlap,
- /* TargetTransformInfo */ TTI,
- /* AtomicElementSize */ std::nullopt,
- /* AverageTripCount */ TripCount);
+ /*InsertBefore=*/Memcpy,
+ /*SrcAddr=*/Memcpy->getRawSource(),
+ /*DstAddr=*/Memcpy->getRawDest(),
+ /*CopyLen=*/Memcpy->getLength(),
+ /*SrcAlign=*/Memcpy->getSourceAlign().valueOrOne(),
+ /*DstAlign=*/Memcpy->getDestAlign().valueOrOne(),
+ /*SrcIsVolatile=*/Memcpy->isVolatile(),
+ /*DstIsVolatile=*/Memcpy->isVolatile(),
+ /*CanOverlap=*/CanOverlap,
+ /*TTI=*/TTI,
+ /*AtomicElementSize=*/std::nullopt,
+ /*AverageTripCount=*/TripCount);
}
}
@@ -1361,13 +1361,13 @@ void llvm::expandMemSetAsLoop(MemSetInst *MemSet,
}
void llvm::expandMemSetPatternAsLoop(MemSetPatternInst *Memset) {
- createMemSetLoop(/* InsertBefore=*/Memset,
- /* DstAddr=*/Memset->getRawDest(),
- /* CopyLen=*/Memset->getLength(),
- /* SetValue=*/Memset->getValue(),
- /* Alignment=*/Memset->getDestAlign().valueOrOne(),
- /* AverageTripCount */ getAverageMemOpLoopTripCount(*Memset),
- /* IsVolatile */ Memset->isVolatile());
+ createMemSetLoop(/*InsertBefore=*/Memset,
+ /*DstAddr=*/Memset->getRawDest(),
+ /*CopyLen=*/Memset->getLength(),
+ /*SetValue=*/Memset->getValue(),
+ /*DstAlign=*/Memset->getDestAlign().valueOrOne(),
+ /*AverageTripCount=*/getAverageMemOpLoopTripCount(*Memset),
+ /*IsVolatile=*/Memset->isVolatile());
}
void llvm::expandAtomicMemCpyAsLoop(AnyMemCpyInst *AtomicMemcpy,
@@ -1376,29 +1376,29 @@ void llvm::expandAtomicMemCpyAsLoop(AnyMemCpyInst *AtomicMemcpy,
assert(AtomicMemcpy->isAtomic());
if (ConstantInt *CI = dyn_cast<ConstantInt>(AtomicMemcpy->getLength())) {
createMemCpyLoopKnownSize(
- /* InsertBefore */ AtomicMemcpy,
- /* SrcAddr */ AtomicMemcpy->getRawSource(),
- /* DstAddr */ AtomicMemcpy->getRawDest(),
- /* CopyLen */ CI,
- /* SrcAlign */ AtomicMemcpy->getSourceAlign().valueOrOne(),
- /* DestAlign */ AtomicMemcpy->getDestAlign().valueOrOne(),
- /* SrcIsVolatile */ AtomicMemcpy->isVolatile(),
- /* DstIsVolatile */ AtomicMemcpy->isVolatile(),
- /* CanOverlap */ false, // SrcAddr & DstAddr may not overlap by spec.
- /* TargetTransformInfo */ TTI,
- /* AtomicElementSize */ AtomicMemcpy->getElementSizeInBytes());
+ /*InsertBefore=*/AtomicMemcpy,
+ /*SrcAddr=*/AtomicMemcpy->getRawSource(),
+ /*DstAddr=*/AtomicMemcpy->getRawDest(),
+ /*CopyLen=*/CI,
+ /*SrcAlign=*/AtomicMemcpy->getSourceAlign().valueOrOne(),
+ /*DstAlign=*/AtomicMemcpy->getDestAlign().valueOrOne(),
+ /*SrcIsVolatile=*/AtomicMemcpy->isVolatile(),
+ /*DstIsVolatile=*/AtomicMemcpy->isVolatile(),
+ /*CanOverlap=*/false, // SrcAddr & DstAddr may not overlap by spec.
+ /*TTI=*/TTI,
+ /*AtomicElementSize=*/AtomicMemcpy->getElementSizeInBytes());
} else {
createMemCpyLoopUnknownSize(
- /* InsertBefore */ AtomicMemcpy,
- /* SrcAddr */ AtomicMemcpy->getRawSource(),
- /* DstAddr */ AtomicMemcpy->getRawDest(),
- /* CopyLen */ AtomicMemcpy->getLength(),
- /* SrcAlign */ AtomicMemcpy->getSourceAlign().valueOrOne(),
- /* DestAlign */ AtomicMemcpy->getDestAlign().valueOrOne(),
- /* SrcIsVolatile */ AtomicMemcpy->isVolatile(),
- /* DstIsVolatile */ AtomicMemcpy->isVolatile(),
- /* CanOverlap */ false, // SrcAddr & DstAddr may not overlap by spec.
- /* TargetTransformInfo */ TTI,
- /* AtomicElementSize */ AtomicMemcpy->getElementSizeInBytes());
+ /*InsertBefore=*/AtomicMemcpy,
+ /*SrcAddr=*/AtomicMemcpy->getRawSource(),
+ /*DstAddr=*/AtomicMemcpy->getRawDest(),
+ /*CopyLen=*/AtomicMemcpy->getLength(),
+ /*SrcAlign=*/AtomicMemcpy->getSourceAlign().valueOrOne(),
+ /*DstAlign=*/AtomicMemcpy->getDestAlign().valueOrOne(),
+ /*SrcIsVolatile=*/AtomicMemcpy->isVolatile(),
+ /*DstIsVolatile=*/AtomicMemcpy->isVolatile(),
+ /*CanOverlap=*/false, // SrcAddr & DstAddr may not overlap by spec.
+ /*TargetTransformInfo=*/TTI,
+ /*AtomicElementSize=*/AtomicMemcpy->getElementSizeInBytes());
}
}
More information about the llvm-branch-commits
mailing list