[llvm-branch-commits] [llvm] release/22.x: [github] Fix release parameter to uncomment download links step (#176386) (PR #176401)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Jan 16 07:14:13 PST 2026


https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/176401

Backport 554d6ae5a5b2e8c29964927ffecc4b09d56311ef

Requested by: @DavidSpickett

>From 8a42f31bb836e5a725257e79d00ee36ef9890702 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at arm.com>
Date: Fri, 16 Jan 2026 15:06:51 +0000
Subject: [PATCH] [github] Fix release parameter to uncomment download links
 step (#176386)

I thought I could remove validate-tag from the "needs" because
release-binaries also "needs" validate-tag. Turns out that we get the
release version from an output of validate-tag and if it isn't in the
"needs" section we get an empty string when substitution happens.
Leading to this error:

./llvm/utils/release/./github-upload-release.py --token "$GITHUB_TOKEN"
--release uncomment_download_links
github-upload-release.py: error: the following arguments are required:
command

Put back validate-tag.

Fixes 822a45f4b4909289f84d119f1e5891b486d74f5e.

(cherry picked from commit 554d6ae5a5b2e8c29964927ffecc4b09d56311ef)
---
 .github/workflows/release-tasks.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/release-tasks.yml b/.github/workflows/release-tasks.yml
index ca8bcfa2c04c9..1258121182069 100644
--- a/.github/workflows/release-tasks.yml
+++ b/.github/workflows/release-tasks.yml
@@ -112,6 +112,7 @@ jobs:
       contents: write # For updating the release message.
     if: '!cancelled()'
     needs:
+      - validate-tag
       - release-binaries
 
     steps:



More information about the llvm-branch-commits mailing list