[llvm-branch-commits] [llvm] [LLVM] Make crashing tests with not use --crash (PR #174297)

[Aiden Grossman via llvm-branch-commits]

boomanaiden154 wrote:

> Is the problem that internal shell not only checks for non zero exit but fails with signal exits?
>
> Maybe that behaviour is actually better since we now need to use --crash for signal exits? But no strong opinion either way.

It's the opposite. The actual `not` command will still return a non-zero exit code if the program crashes unless `--crash` is specified. The internal shell version will return zero as long as the command does not return exit code zero. My thinking is similar to yours, that the old behavior is better since we need to specify `--crash` for signal exits.

https://github.com/llvm/llvm-project/pull/174297