[llvm-branch-commits] [libcxx] release/22.x: [libc++] Fix vector::append_range growing before the capacity is reached (#183264) (PR #183722)

[Nikolas Klauser via llvm-branch-commits]

philnik777 wrote:

> I'm a little on the fence about this change, what are the downsides if we decide not to take this change on the release branch?

This is a conformance issue, which IMO should definitely be backported. If this were in e.g. `push_back` we would definitely break programs that expect iterators to not be invalidated. The only reason this isn't a huge deal right now is that the interface is relatively new. use-after-free accesses are still a definite possibility due to this bug though.

https://github.com/llvm/llvm-project/pull/183722