[llvm-branch-commits] [clang] [FlowSensitive] [StatusOr] cache return values for all accessors (PR #179807)

[Florian Mayer via llvm-branch-commits]

https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/179807

>From 8750fb676fe70705d681ce8fc77223bb0c29e037 Mon Sep 17 00:00:00 2001
From: Florian Mayer <fmayer at google.com>
Date: Thu, 5 Feb 2026 10:07:47 -0800
Subject: [PATCH] address feedback

Created using spr 1.3.6
---
 .../FlowSensitive/Models/UncheckedStatusOrAccessModel.cpp    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/clang/lib/Analysis/FlowSensitive/Models/UncheckedStatusOrAccessModel.cpp b/clang/lib/Analysis/FlowSensitive/Models/UncheckedStatusOrAccessModel.cpp
index e9aa21ee00c69..7dc3f5872f4d8 100644
--- a/clang/lib/Analysis/FlowSensitive/Models/UncheckedStatusOrAccessModel.cpp
+++ b/clang/lib/Analysis/FlowSensitive/Models/UncheckedStatusOrAccessModel.cpp
@@ -872,7 +872,7 @@ static void transferStatusOrReturningCall(const CallExpr *Expr,
     initializeStatusOr(*StatusOrLoc, State.Env);
 }
 
-static bool doHandleConstStatusOrAccessorMemberCall(
+static bool doHandleConstAccessorMemberCall(
     const CallExpr *Expr, RecordStorageLocation *RecordLoc,
     const MatchFinder::MatchResult &Result, LatticeTransferState &State) {
   if (RecordLoc == nullptr)
@@ -898,8 +898,7 @@ static bool doHandleConstStatusOrAccessorMemberCall(
 static void handleConstAccessorMemberCall(
     const CallExpr *Expr, RecordStorageLocation *RecordLoc,
     const MatchFinder::MatchResult &Result, LatticeTransferState &State) {
-  if (!doHandleConstStatusOrAccessorMemberCall(Expr, RecordLoc, Result,
-                                               State) &&
+  if (!doHandleConstAccessorMemberCall(Expr, RecordLoc, Result, State) &&
       isStatusOrType(Expr->getType()))
     transferStatusOrReturningCall(Expr, State);
 }