[llvm-branch-commits] [llvm] Fix profile metadata propagation for umax in InstCombine (PR #179332)

[Mircea Trofin via llvm-branch-commits]

================
@@ -2117,8 +2122,13 @@ Instruction *InstCombinerImpl::visitCallInst(CallInst &CI) {
         return nullptr;
 
       Value *Cmp = Builder.CreateICmpEQ(X, ConstantInt::get(X->getType(), 0));
-      Value *NewSelect =
-          Builder.CreateSelect(Cmp, ConstantInt::get(X->getType(), 1), A);
+      Value *NewSelect = nullptr;
+      if (!ProfcheckDisableMetadataFixes)
----------------
mtrofin wrote:

If they are always unknown, no need to do it under the flag. The goal of the flag is to do a perf ablation study, and for those purposes, unknown or "nothing" have the same effect.

https://github.com/llvm/llvm-project/pull/179332