[llvm-branch-commits] [clang] [ExposeObjCDirect] Optimizations (PR #170619)

[Oliver Hunt via llvm-branch-commits]

================
@@ -2190,6 +2190,20 @@ CodeGen::RValue CGObjCCommonMac::EmitMessageSend(
     CallSite->setDoesNotReturn();
   }
 
+  // If this was a class method call on a non-weakly-linked class, record it
+  // as realized for the "previously realized" heuristic.
+  if (ClassReceiver && Method && !isWeakLinkedClass(ClassReceiver)) {
+    if (llvm::BasicBlock *CurrentBB = CGF.Builder.GetInsertBlock())
----------------
ojhunt wrote:

Braces around this if block - technical the rules are "no brace for a single statement" but comments make that even more silly.

These comments seem more verbose than necessary to me, but not so bad I think they need to be changed

The style doesn't quite match the surrounding style, but that's just due to the age of this code, when modifying or adding we try to update to the new style as we go.

https://github.com/llvm/llvm-project/pull/170619