[llvm-branch-commits] [clang] [SSAF][PointerFlow] Change unsafe-buffer reachability analysis back to simple graph search (PR #218209)

[Balázs Benics via llvm-branch-commits]

https://github.com/steakhal approved this pull request.

Looks correct but there is one drawback with LIT tests:
The completeness is not checked (there might be more edges that are not checked!). You only have `CHECK-NOT` at the end. So it is hard to assert completeness.

It's also arguably easier to patch unittests than fiddling with FileCheck lines, `sed` transformations etc. So IMO this patch doesn't improve readability. If anything, it probably regresses the quality.

I don't have a really strong opinion about this, so I'll approve this and let you judge these complaints.

https://github.com/llvm/llvm-project/pull/218209