[llvm-branch-commits] [libc] [llvm] [libc][bazel] Add targets for startup objects on linux (PR #218995)

[Alexey Samsonov via llvm-branch-commits]

================
@@ -0,0 +1,176 @@
+# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+"""LLVM libc starlark rules for building startup objects."""
+
+load("@bazel_skylib//lib:paths.bzl", "paths")
+load("@rules_cc//cc:action_names.bzl", "ACTION_NAMES")
+load("@rules_cc//cc:find_cc_toolchain.bzl", "find_cc_toolchain", "use_cc_toolchain")
+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
+load("//libc:libc_build_rules.bzl", "libc_startup_library")
+
+def _get_compilation_outputs(deps):
+    outputs = []
+    for dep in deps:
+        if OutputGroupInfo in dep and "compilation_outputs" in dep[OutputGroupInfo]:
+            outputs.extend(dep[OutputGroupInfo].compilation_outputs.to_list())
+    return outputs
+
+def _extract_object_file_impl(ctx):
+    output = ctx.actions.declare_file(ctx.label.name + ".o")
+    input_objs = _get_compilation_outputs([ctx.attr.dep])
+    if len(input_objs) != 1:
+        fail("Expected exactly one input object, got: {}".format(input_objs))
+
+    input_obj = input_objs[0]
+
+    ctx.actions.symlink(
+        output = output,
+        target_file = input_obj,
+    )
+
+    return [DefaultInfo(files = depset([output]))]
+
+_extract_object_file = rule(
+    implementation = _extract_object_file_impl,
+    attrs = {
+        "dep": attr.label(
+            mandatory = True,
+            providers = [CcInfo],
+        ),
+    },
+)
+
+def libc_startup_object(name, src, visibility = None, **kwargs):
+    """Compiles a C++ source file into a startup object file.
+
+    Args:
+        name: The name of the target.
+        src: The C++ source file to compile.
+        visibility: Visibility of targets created by this macro.
+        **kwargs: Other arguments to
+    """
+    library_name = name + "_lib"
+    libc_startup_library(
+        name = library_name,
+        srcs = [src],
+        visibility = visibility,
+        **kwargs
+    )
+    _extract_object_file(
+        name = name,
+        dep = ":" + library_name,
+        visibility = visibility,
+    )
+
+def _filter_flags(
+        flags,
+        separate_flag_names,
+        joined_flag_prefixes):
+    """Filters flags to those in joined_flag_prefixes or separate_flag_names.
+
+    Args:
+        flags: The flags to filter.
+        separate_flag_names: Names of flags whose value is specified separately
+            from the flag (for example "--target value").
+        joined_flag_prefixes: Prefixes of flags whose value is joined to the
+            flag name (for example, --target=value).
+    """
+    filtered_flags = []
+    skip_next = False
+    for i, flag in enumerate(flags):
+        if skip_next:
+            skip_next = False
+            continue
+
+        if flag in separate_flag_names:
+            if i + 1 < len(flags):
+                filtered_flags.append(flag)
+                filtered_flags.append(flags[i + 1])
+                skip_next = True
+            continue
+
+        for prefix in joined_flag_prefixes:
+            if flag.startswith(prefix):
+                filtered_flags.append(flag)
+                continue
+
+    return filtered_flags
+
+def _merge_relocatable_object_impl(ctx):
+    cc_toolchain = find_cc_toolchain(ctx)
+    output = ctx.actions.declare_file(ctx.label.name + ".o")
+
+    input_objs = _get_compilation_outputs(ctx.attr.deps)
+
+    feature_configuration = cc_common.configure_features(
+        ctx = ctx,
+        cc_toolchain = cc_toolchain,
+        requested_features = ctx.features,
+        unsupported_features = ctx.disabled_features,
+    )
+    link_variables = cc_common.create_link_variables(
+        cc_toolchain = cc_toolchain,
+        feature_configuration = feature_configuration,
+        is_linking_dynamic_library = False,
+    )
+    link_flags = cc_common.get_memory_inefficient_command_line(
+        feature_configuration = feature_configuration,
+        action_name = ACTION_NAMES.cpp_link_executable,
+        variables = link_variables,
+    )
+    linker = cc_common.get_tool_for_action(
+        feature_configuration = feature_configuration,
+        action_name = ACTION_NAMES.cpp_link_executable,
+    )
+    relocatable_link_flags = _filter_flags(
+        link_flags,
+        ("-target", "--target", "--sysroot", "-isysroot"),
----------------
vonosmas wrote:

Should these be lists instead of tuples?

https://github.com/llvm/llvm-project/pull/218995