[llvm-branch-commits] [clang] [llvm] release/23.x: Revert "Revert "workflows/release-binaries: Disable flang on Darwin (#164667)"" (#218978) (PR #219253)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Aug 27 10:50:54 PDT 2026
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/219253
Backport 3d771f477aa026ca41cb3c4e492d7a07fa852cbe
Requested by: @dyung
>From 467add7adfab0838c48bbcf17987e903f23a9b9d Mon Sep 17 00:00:00 2001
From: Douglas Yung <douglas.yung at sony.com>
Date: Thu, 27 Aug 2026 06:40:40 +0700
Subject: [PATCH] Revert "Revert "workflows/release-binaries: Disable flang on
Darwin (#164667)"" (#218978)
Reverts llvm/llvm-project#216667
This change was ported to the `release/23.x` branch in #217059, and when
we created the first release that included this change (3.1.0), the job
for the MacOS ARM binaries was killed when the job hit the 6 hour mark.
Previous 3.1.0-rc release did not include this change and all completed
well within the 6 hour time out.
To enable the job that builds the release binaries to complete within
the allotted time, I am reverting this change which will essentially
disable flang from building on Darwin.
In the future if we get faster builders, we can explore re-enabling
building flang.
(cherry picked from commit 3d771f477aa026ca41cb3c4e492d7a07fa852cbe)
---
.github/workflows/release-binaries.yml | 7 -------
clang/cmake/caches/Release.cmake | 10 ++++++++--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 78290d7aa767f..b113456a319ca 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -157,13 +157,6 @@ jobs:
target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_BOOTSTRAP_COMPILER_RT_ENABLE_IOS=OFF"
if [ "$RUNNER_ARCH" = "ARM64" ]; then
arches=arm64
- else
- arches=x86_64
- # Disable Flang builds on macOS x86_64. The FortranLower library takes
- # 2-3 hours to build on macOS, much slower than on Linux.
- # The long build time causes the release build to time out on x86_64,
- # so we need to disable flang there.
- target_cmake_flags="$target_cmake_flags -DLLVM_RELEASE_ENABLE_PROJECTS='clang;lld;lldb;clang-tools-extra;polly;mlir'"
fi
target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_BOOTSTRAP_DARWIN_osx_ARCHS=$arches -DBOOTSTRAP_BOOTSTRAP_DARWIN_osx_BUILTIN_ARCHS=$arches"
fi
diff --git a/clang/cmake/caches/Release.cmake b/clang/cmake/caches/Release.cmake
index 5bea5fa585fce..b0bc3ebfe5cb6 100644
--- a/clang/cmake/caches/Release.cmake
+++ b/clang/cmake/caches/Release.cmake
@@ -30,13 +30,19 @@ endfunction()
#
# cmake -D LLVM_RELEASE_ENABLE_PGO=ON -C Release.cmake
-set (DEFAULT_PROJECTS "clang;lld;lldb;clang-tools-extra;polly;mlir;flang")
+set (DEFAULT_PROJECTS "clang;lld;lldb;clang-tools-extra;polly;mlir")
# bolt only supports ELF, so only enable it for Linux.
if (${CMAKE_HOST_SYSTEM_NAME} MATCHES "Linux")
list(APPEND DEFAULT_PROJECTS "bolt")
endif()
-set (DEFAULT_RUNTIMES "compiler-rt;libcxx;openmp;flang-rt")
+set (DEFAULT_RUNTIMES "compiler-rt;libcxx;openmp")
+# Don't build flang on Darwin due to:
+# https://github.com/llvm/llvm-project/issues/160546
+if (NOT ${CMAKE_HOST_SYSTEM_NAME} MATCHES "Darwin")
+ list(APPEND DEFAULT_PROJECTS "flang")
+ list(APPEND DEFAULT_RUNTIMES "flang-rt")
+endif()
if (NOT WIN32)
list(APPEND DEFAULT_RUNTIMES "libcxxabi" "libunwind")
More information about the llvm-branch-commits
mailing list