[llvm-branch-commits] [clang] c9ba8a4 - Revert "[SSAF] Fix a stage2 test failure with ASan-instrumented clang - conti…"

[via llvm-branch-commits]

Author: Thurston Dang
Date: 2026-08-21T20:53:04-07:00
New Revision: c9ba8a43a678978a7155f6587971937d31327802

URL: https://github.com/llvm/llvm-project/commit/c9ba8a43a678978a7155f6587971937d31327802
DIFF: https://github.com/llvm/llvm-project/commit/c9ba8a43a678978a7155f6587971937d31327802.diff

LOG: Revert "[SSAF] Fix a stage2 test failure with ASan-instrumented clang - conti…"

This reverts commit ede975d9f046441b9793e02bab190bd0bafb1fa2.

Added: 
    

Modified: 
    clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/CMakeLists.txt
    clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp

Removed: 
    


################################################################################
diff  --git a/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/CMakeLists.txt b/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/CMakeLists.txt
index dbcb1e4c37ad9..7f170be16d2cc 100644
--- a/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/CMakeLists.txt
+++ b/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/CMakeLists.txt
@@ -14,13 +14,3 @@ target_include_directories(SSAFTestTransformationPlugin PRIVATE
   $<TARGET_PROPERTY:clangScalableStaticAnalysisCore,INTERFACE_INCLUDE_DIRECTORIES>
   $<TARGET_PROPERTY:clangScalableStaticAnalysisSourceTransformation,INTERFACE_INCLUDE_DIRECTORIES>
   )
-
-# The plugin is loaded into a clang that may be built with sanitizers (e.g. the
-# stage-2 -DLLVM_USE_SANITIZER=Address bots), but does not need instrumenting
-# itself. With ASan, -Wl,-dead_strip drops anonymous constants that ASan's
-# metadata still references, leaving dangling flat-namespace binds that break
-# dlopen ("symbol not found in flat namespace 'l___unnamed_NNNN'"). Opt out.
-if(LLVM_USE_SANITIZER)
-  target_compile_options(SSAFTestTransformationPlugin PRIVATE -fno-sanitize=all)
-  target_link_options(SSAFTestTransformationPlugin PRIVATE -fno-sanitize=all)
-endif()

diff  --git a/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp b/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp
index d3edc34882cef..33a8319cd5b6a 100644
--- a/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp
+++ b/clang/test/Analysis/Scalable/source-edit-generation/Plugins/TestTransformationPlugin/TestTransformation.cpp
@@ -94,7 +94,10 @@ namespace clang::ssaf {
 volatile int SSAFTestTransformationAnchorSource = 0;
 } // namespace clang::ssaf
 
+// This global causes issue in stage2 with ASan-instrumented clang so
+// adding the no-ASan attribute.
 static TransformationRegistry::Add<TestTransformation>
+    __attribute__((no_sanitize("address")))
     RegisterTestTransformation("test-transformation",
                                "Test transformation for the SSAF "
                                "source-edit-generation lit suite");