[llvm-branch-commits] [libc] [llvm] [libc] Make remainder functions use the emulated float128 type (PR #217578)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Fri Aug 21 03:49:39 PDT 2026
https://github.com/Sukumarsawant updated https://github.com/llvm/llvm-project/pull/217578
>From b0e94f55c733e655c3840fd751bea1f79d148c26 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Thu, 20 Aug 2026 15:45:09 +0530
Subject: [PATCH 1/3] fmodf128
---
libc/config/baremetal/aarch64/entrypoints.txt | 2 +-
libc/config/baremetal/arm/entrypoints.txt | 2 +-
libc/config/baremetal/riscv/entrypoints.txt | 2 +-
libc/config/darwin/aarch64/entrypoints.txt | 2 +-
libc/config/darwin/x86_64/entrypoints.txt | 1 +
libc/config/freebsd/x86_64/entrypoints.txt | 2 +-
libc/config/gpu/amdgpu/entrypoints.txt | 1 +
libc/config/gpu/nvptx/entrypoints.txt | 1 +
libc/config/linux/aarch64/entrypoints.txt | 2 +-
libc/config/linux/arm/entrypoints.txt | 1 +
libc/config/linux/riscv/entrypoints.txt | 2 +-
libc/config/linux/x86_64/entrypoints.txt | 2 +-
libc/config/windows/entrypoints.txt | 1 +
libc/shared/math/fmodf128.h | 6 ------
libc/src/__support/math/CMakeLists.txt | 2 +-
libc/src/__support/math/fmodf128.h | 13 +++++--------
libc/src/math/fmodf128.h | 5 +++++
libc/src/math/generic/CMakeLists.txt | 1 +
libc/src/math/generic/fmodf128.cpp | 6 +++++-
libc/test/shared/shared_math_constexpr_test.cpp | 4 ++--
libc/test/shared/shared_math_test.cpp | 2 +-
libc/test/src/math/smoke/CMakeLists.txt | 1 +
libc/test/src/math/smoke/fmodf128_test.cpp | 5 +++++
utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++-
.../libc/test/src/math/smoke/BUILD.bazel | 3 +++
25 files changed, 45 insertions(+), 28 deletions(-)
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index e070c040d85df..94b9beab3186b 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -463,6 +463,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
@@ -769,7 +770,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.faddf128
libc.src.math.fdivf128
libc.src.math.ffmaf128
- libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
libc.src.math.fromfpf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 68e39c534c16b..4ed723471948a 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -475,6 +475,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
@@ -780,7 +781,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.faddf128
libc.src.math.fdivf128
libc.src.math.ffmaf128
- libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
libc.src.math.fromfpf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index 99d35e8342273..a4aa64ae2658b 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -471,6 +471,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
# libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
@@ -777,7 +778,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.faddf128
libc.src.math.fdivf128
libc.src.math.ffmaf128
- # libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
libc.src.math.fromfpf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index 6b4d66fefbc9a..e7424b500d815 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -282,6 +282,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
@@ -589,7 +590,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.faddf128
libc.src.math.fdivf128
libc.src.math.ffmaf128
- libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
libc.src.math.fromfpf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index 5db07ccec5202..cf3e813ee1e7c 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -174,6 +174,7 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.fminl
#libc.src.math.fmod
#libc.src.math.fmodf
+ #libc.src.math.fmodf128
#libc.src.math.frexp
#libc.src.math.frexpf
#libc.src.math.frexpl
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index e5f71d80c1c87..50bb63d933ef3 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -217,6 +217,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmul
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.frexp
libc.src.math.frexpf
@@ -528,7 +529,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.faddf128
libc.src.math.fdivf128
libc.src.math.ffmaf128
- libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
libc.src.math.fromfpf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index ea238f7565b3b..230ac9c7e5b9a 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -410,6 +410,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index 4a18baf208402..907721639a2c9 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -406,6 +406,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 07e5b4f6b1a9d..d133dbff090c9 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -623,6 +623,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
@@ -923,7 +924,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.faddf128
libc.src.math.fdivf128
libc.src.math.ffmaf128
- libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
libc.src.math.fromfpf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 0a0f38f983b94..c4caf995c8c71 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -450,6 +450,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmul
libc.src.math.frexp
libc.src.math.frexpf
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 05a8b0d8a2cb1..5847024ca6443 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -691,6 +691,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
@@ -1008,7 +1009,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.faddf128
libc.src.math.fdivf128
libc.src.math.ffmaf128
- libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
libc.src.math.fromfpf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 3eaf9936132aa..c037c420f6e16 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -701,6 +701,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fminl
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.fmul
libc.src.math.fmull
@@ -1018,7 +1019,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.faddf128
libc.src.math.fdivf128
libc.src.math.ffmaf128
- libc.src.math.fmodf128
libc.src.math.fmulf128
libc.src.math.frexpf128
libc.src.math.fromfpf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index bfc517b272fc6..cb02aa7bd4127 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -250,6 +250,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.fmul
libc.src.math.fmod
libc.src.math.fmodf
+ libc.src.math.fmodf128
libc.src.math.fmodl
libc.src.math.frexp
libc.src.math.frexpf
diff --git a/libc/shared/math/fmodf128.h b/libc/shared/math/fmodf128.h
index 0000893546763..97bee8e09dca8 100644
--- a/libc/shared/math/fmodf128.h
+++ b/libc/shared/math/fmodf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_FMODF128_H
#define LLVM_LIBC_SHARED_MATH_FMODF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/fmodf128.h"
@@ -24,6 +20,4 @@ using math::fmodf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_FMODF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index e644c917de5ee..22e66615e12f9 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -1426,7 +1426,7 @@ add_header_library(
HDRS
fmodf128.h
DEPENDS
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.generic.fmod
libc.src.__support.macros.config
)
diff --git a/libc/src/__support/math/fmodf128.h b/libc/src/__support/math/fmodf128.h
index 7ed105b81af48..5a1b29c1997bc 100644
--- a/libc/src/__support/math/fmodf128.h
+++ b/libc/src/__support/math/fmodf128.h
@@ -9,23 +9,20 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMODF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_FMODF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/FPUtil/generic/FMod.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
-LIBC_INLINE constexpr float128 fmodf128(float128 x, float128 y) {
- return fputil::generic::FMod<float128>::eval(x, y);
+using LIBC_NAMESPACE::fputil::Float128;
+
+LIBC_INLINE constexpr Float128 fmodf128(Float128 x, Float128 y) {
+ return fputil::generic::FMod<Float128>::eval(x, y);
}
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMODF128_H
diff --git a/libc/src/math/fmodf128.h b/libc/src/math/fmodf128.h
index 908fc61a19497..4e18c34c5a83b 100644
--- a/libc/src/math/fmodf128.h
+++ b/libc/src/math/fmodf128.h
@@ -9,11 +9,16 @@
#ifndef LLVM_LIBC_SRC_MATH_FMODF128_H
#define LLVM_LIBC_SRC_MATH_FMODF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
float128 fmodf128(float128 x, float128 y);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index ca86078012fe1..1ddcea1a50eaf 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -3459,6 +3459,7 @@ add_entrypoint_object(
HDRS
../fmodf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.fmodf128
)
diff --git a/libc/src/math/generic/fmodf128.cpp b/libc/src/math/generic/fmodf128.cpp
index c72ec7ec1cdf5..fb22a165b2aa8 100644
--- a/libc/src/math/generic/fmodf128.cpp
+++ b/libc/src/math/generic/fmodf128.cpp
@@ -7,12 +7,16 @@
//===----------------------------------------------------------------------===//
#include "src/math/fmodf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/fmodf128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(float128, fmodf128, (float128 x, float128 y)) {
- return math::fmodf128(x, y);
+ return cpp::bit_cast<float128>(
+ math::fmodf128(cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index 6f3b433a30938..4d137f1602dd9 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,6 +381,8 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+static_assert(0 ==
+ LIBC_NAMESPACE::shared::fmodf128(Float128(4.0), Float128(2.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::copysignf128(Float128(0.0),
Float128(0.0)));
@@ -477,8 +479,6 @@ constexpr float128 TOTALORDERMAGF128_Y = float128(0.0);
static_assert(1 ==
LIBC_NAMESPACE::shared::totalordermagf128(&TOTALORDERMAGF128_X,
&TOTALORDERMAGF128_Y));
-static_assert(0 ==
- LIBC_NAMESPACE::shared::fmodf128(float128(4.0), float128(2.0)));
static_assert(float128(0.0) == [] {
float128 iptr{};
return LIBC_NAMESPACE::shared::modff128(float128(0.0), &iptr);
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 919ac4a509420..76e655d14e9cd 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -587,6 +587,7 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+ LIBC_NAMESPACE::shared::fmodf128(Float128(1.0), Float128(1.0));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128(
Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0)));
@@ -734,7 +735,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
float128 totalordermagf128_y = float128(0.0);
EXPECT_EQ(1, LIBC_NAMESPACE::shared::totalordermagf128(&totalordermagf128_x,
&totalordermagf128_y));
- LIBC_NAMESPACE::shared::fmodf128(float128(1.0), float128(1.0));
float128 modff128_iptr = float128(0.0);
EXPECT_FP_EQ(float128(0.0),
LIBC_NAMESPACE::shared::modff128(float128(0.0), &modff128_iptr));
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 66a4f3ac65710..d0c9c14110583 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -4679,6 +4679,7 @@ add_fp_unittest(
DEPENDS
libc.hdr.errno_macros
libc.hdr.fenv_macros
+ libc.src.__support.FPUtil.float128
libc.src.math.fmodf128
libc.src.__support.FPUtil.fenv_impl
# FIXME: Currently fails on the GPU build.
diff --git a/libc/test/src/math/smoke/fmodf128_test.cpp b/libc/test/src/math/smoke/fmodf128_test.cpp
index f75aadac84386..2afae9b9e98f4 100644
--- a/libc/test/src/math/smoke/fmodf128_test.cpp
+++ b/libc/test/src/math/smoke/fmodf128_test.cpp
@@ -7,7 +7,12 @@
//===----------------------------------------------------------------------===//
#include "FModTest.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/math/fmodf128.h"
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
LIST_FMOD_TESTS(float128, LIBC_NAMESPACE::fmodf128)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index fa5bb354a999f..e3933e228e8e5 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -5937,9 +5937,9 @@ libc_support_library(
name = "__support_math_fmodf128",
hdrs = ["src/__support/math/fmodf128.h"],
deps = [
+ ":__support_fputil_float128",
":__support_fputil_generic_fmod",
":__support_macros_config",
- ":llvm_libc_types_float128",
],
)
@@ -12179,6 +12179,8 @@ libc_math_function(
libc_math_function(
name = "fmodf128",
additional_deps = [
+ ":__support_cpp_bit",
+ ":__support_fputil_float128",
":__support_math_fmodf128",
],
)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index 53b0077a9acad..cad383637dfcd 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -831,6 +831,9 @@ math_test(
math_test(
name = "fmodf128",
hdrs = ["FModTest.h"],
+ deps = [
+ "//libc:__support_fputil_float128",
+ ],
)
math_test(
>From 5cb86897cbdcfe21e4c63f7a604665a654754f66 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Thu, 20 Aug 2026 16:07:11 +0530
Subject: [PATCH 2/3] remainderf128
---
libc/config/baremetal/aarch64/entrypoints.txt | 2 +-
libc/config/baremetal/arm/entrypoints.txt | 2 +-
libc/config/baremetal/riscv/entrypoints.txt | 2 +-
libc/config/darwin/aarch64/entrypoints.txt | 2 +-
libc/config/darwin/x86_64/entrypoints.txt | 1 +
libc/config/freebsd/x86_64/entrypoints.txt | 2 +-
libc/config/gpu/amdgpu/entrypoints.txt | 1 +
libc/config/gpu/nvptx/entrypoints.txt | 1 +
libc/config/linux/aarch64/entrypoints.txt | 2 +-
libc/config/linux/arm/entrypoints.txt | 1 +
libc/config/linux/riscv/entrypoints.txt | 2 +-
libc/config/linux/x86_64/entrypoints.txt | 2 +-
libc/config/windows/entrypoints.txt | 1 +
libc/shared/math/remainderf128.h | 6 ------
libc/src/__support/math/CMakeLists.txt | 2 +-
libc/src/__support/math/remainderf128.h | 11 ++++-------
libc/src/math/generic/CMakeLists.txt | 1 +
libc/src/math/generic/remainderf128.cpp | 6 +++++-
libc/src/math/remainderf128.h | 5 +++++
libc/test/shared/shared_math_constexpr_test.cpp | 6 +++---
libc/test/shared/shared_math_test.cpp | 4 ++--
utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++-
22 files changed, 37 insertions(+), 29 deletions(-)
diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt
index 94b9beab3186b..8c8223b6a762b 100644
--- a/libc/config/baremetal/aarch64/entrypoints.txt
+++ b/libc/config/baremetal/aarch64/entrypoints.txt
@@ -559,6 +559,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
@@ -786,7 +787,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.logbf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.remainderf128
libc.src.math.remquof128
libc.src.math.scalblnf128
libc.src.math.scalbnf128
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 4ed723471948a..4a81dbdafc255 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -571,6 +571,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
@@ -797,7 +798,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.logbf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.remainderf128
libc.src.math.remquof128
libc.src.math.scalblnf128
libc.src.math.scalbnf128
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index a4aa64ae2658b..168e1ab056391 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -567,6 +567,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
@@ -794,7 +795,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.logbf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.remainderf128
libc.src.math.remquof128
libc.src.math.scalblnf128
libc.src.math.scalbnf128
diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt
index e7424b500d815..d8949698b2a4f 100644
--- a/libc/config/darwin/aarch64/entrypoints.txt
+++ b/libc/config/darwin/aarch64/entrypoints.txt
@@ -378,6 +378,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
@@ -606,7 +607,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.logbf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.remainderf128
libc.src.math.remquof128
libc.src.math.scalblnf128
libc.src.math.scalbnf128
diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt
index cf3e813ee1e7c..9fee798ed1c7a 100644
--- a/libc/config/darwin/x86_64/entrypoints.txt
+++ b/libc/config/darwin/x86_64/entrypoints.txt
@@ -231,6 +231,7 @@ set(TARGET_LIBM_ENTRYPOINTS
#libc.src.math.nexttowardl
#libc.src.math.nextupf128
#libc.src.math.remainderf
+ #libc.src.math.remainderf128
#libc.src.math.remainder
#libc.src.math.remainderl
#libc.src.math.remquof
diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt
index 50bb63d933ef3..a4f1b11e6ca49 100644
--- a/libc/config/freebsd/x86_64/entrypoints.txt
+++ b/libc/config/freebsd/x86_64/entrypoints.txt
@@ -281,6 +281,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.pow
libc.src.math.powf
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainder
libc.src.math.remainderl
libc.src.math.remquof
@@ -544,7 +545,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.logbf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.remainderf128
libc.src.math.remquof128
libc.src.math.scalblnf128
libc.src.math.scalbnf128
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index 230ac9c7e5b9a..0ca733e094449 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -502,6 +502,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index 907721639a2c9..12d87ae19b968 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -499,6 +499,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index d133dbff090c9..eb450c5f32e50 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -719,6 +719,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
@@ -940,7 +941,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.logbf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.remainderf128
libc.src.math.remquof128
libc.src.math.scalblnf128
libc.src.math.scalbnf128
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index c4caf995c8c71..068532098f7b7 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -533,6 +533,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index 5847024ca6443..020218b038091 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -787,6 +787,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
@@ -1025,7 +1026,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.logbf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.remainderf128
libc.src.math.remquof128
libc.src.math.scalblnf128
libc.src.math.scalbnf128
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index c037c420f6e16..fa20c517bb9d8 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -797,6 +797,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.powf
libc.src.math.remainder
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainderl
libc.src.math.remquo
libc.src.math.remquof
@@ -1035,7 +1036,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128)
libc.src.math.logbf128
libc.src.math.modff128
libc.src.math.nanf128
- libc.src.math.remainderf128
libc.src.math.remquof128
libc.src.math.scalblnf128
libc.src.math.scalbnf128
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index cb02aa7bd4127..69a9625c556be 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -314,6 +314,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.pow
libc.src.math.powf
libc.src.math.remainderf
+ libc.src.math.remainderf128
libc.src.math.remainder
libc.src.math.remainderl
libc.src.math.remquof
diff --git a/libc/shared/math/remainderf128.h b/libc/shared/math/remainderf128.h
index b1d02de64c20b..d0d598c0c9c73 100644
--- a/libc/shared/math/remainderf128.h
+++ b/libc/shared/math/remainderf128.h
@@ -9,10 +9,6 @@
#ifndef LLVM_LIBC_SHARED_MATH_REMAINDERF128_H
#define LLVM_LIBC_SHARED_MATH_REMAINDERF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "shared/libc_common.h"
#include "src/__support/math/remainderf128.h"
@@ -24,6 +20,4 @@ using math::remainderf128;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SHARED_MATH_REMAINDERF128_H
diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt
index 22e66615e12f9..922470d0f5700 100644
--- a/libc/src/__support/math/CMakeLists.txt
+++ b/libc/src/__support/math/CMakeLists.txt
@@ -2298,7 +2298,7 @@ add_header_library(
HDRS
remainderf128.h
DEPENDS
- libc.include.llvm-libc-types.float128
+ libc.src.__support.FPUtil.float128
libc.src.__support.FPUtil.division_and_remainder_operations
libc.src.__support.macros.config
)
diff --git a/libc/src/__support/math/remainderf128.h b/libc/src/__support/math/remainderf128.h
index cd3ed15a7b1a2..3ef5d7e365caf 100644
--- a/libc/src/__support/math/remainderf128.h
+++ b/libc/src/__support/math/remainderf128.h
@@ -9,17 +9,16 @@
#ifndef LLVM_LIBC_SRC___SUPPORT_MATH_REMAINDERF128_H
#define LLVM_LIBC_SRC___SUPPORT_MATH_REMAINDERF128_H
-#include "include/llvm-libc-types/float128.h"
-
-#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#include "src/__support/FPUtil/DivisionAndRemainderOperations.h"
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
namespace LIBC_NAMESPACE_DECL {
namespace math {
-LIBC_INLINE constexpr float128 remainderf128(float128 x, float128 y) {
+using LIBC_NAMESPACE::fputil::Float128;
+
+LIBC_INLINE constexpr Float128 remainderf128(Float128 x, Float128 y) {
int quotient{};
return fputil::remquo(x, y, quotient);
}
@@ -27,6 +26,4 @@ LIBC_INLINE constexpr float128 remainderf128(float128 x, float128 y) {
} // namespace math
} // namespace LIBC_NAMESPACE_DECL
-#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
-
#endif // LLVM_LIBC_SRC___SUPPORT_MATH_REMAINDERF128_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 1ddcea1a50eaf..9e86433cea2ff 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -2840,6 +2840,7 @@ add_entrypoint_object(
HDRS
../remainderf128.h
DEPENDS
+ libc.src.__support.CPP.bit
libc.src.__support.math.remainderf128
)
diff --git a/libc/src/math/generic/remainderf128.cpp b/libc/src/math/generic/remainderf128.cpp
index 072d19737d382..47b265bb2f47c 100644
--- a/libc/src/math/generic/remainderf128.cpp
+++ b/libc/src/math/generic/remainderf128.cpp
@@ -7,12 +7,16 @@
//===----------------------------------------------------------------------===//
#include "src/math/remainderf128.h"
+#include "src/__support/CPP/bit.h"
#include "src/__support/math/remainderf128.h"
namespace LIBC_NAMESPACE_DECL {
+using LIBC_NAMESPACE::fputil::Float128;
+
LLVM_LIBC_FUNCTION(float128, remainderf128, (float128 x, float128 y)) {
- return math::remainderf128(x, y);
+ return cpp::bit_cast<float128>(math::remainderf128(
+ cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y)));
}
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/remainderf128.h b/libc/src/math/remainderf128.h
index 57f770a853d68..8f0e763a2d1ab 100644
--- a/libc/src/math/remainderf128.h
+++ b/libc/src/math/remainderf128.h
@@ -9,11 +9,16 @@
#ifndef LLVM_LIBC_SRC_MATH_REMAINDERF128_H
#define LLVM_LIBC_SRC_MATH_REMAINDERF128_H
+#include "src/__support/FPUtil/float128.h"
#include "src/__support/macros/config.h"
#include "src/__support/macros/properties/types.h"
namespace LIBC_NAMESPACE_DECL {
+#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128
+using float128 = LIBC_NAMESPACE::fputil::Float128;
+#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128
+
float128 remainderf128(float128 x, float128 y);
} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index 4d137f1602dd9..49e899fda6943 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,6 +381,9 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+static_assert(float128(0.0) ==
+ LIBC_NAMESPACE::shared::remainderf128(Float128(1.0),
+ Float128(1.0)));
static_assert(0 ==
LIBC_NAMESPACE::shared::fmodf128(Float128(4.0), Float128(2.0)));
static_assert(Float128(0.0) ==
@@ -483,9 +486,6 @@ static_assert(float128(0.0) == [] {
float128 iptr{};
return LIBC_NAMESPACE::shared::modff128(float128(0.0), &iptr);
}());
-static_assert(float128(0.0) ==
- LIBC_NAMESPACE::shared::remainderf128(float128(1.0),
- float128(1.0)));
static_assert(float128(0.0) == [] {
int exp{};
return LIBC_NAMESPACE::shared::remquof128(float128(1.0), float128(1.0), &exp);
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 76e655d14e9cd..1eccd4a1ea585 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -587,6 +587,8 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
+ EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::remainderf128(
+ Float128(1.0), Float128(1.0)));
LIBC_NAMESPACE::shared::fmodf128(Float128(1.0), Float128(1.0));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128(
Float128(0.0), Float128(0.0)));
@@ -739,8 +741,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
EXPECT_FP_EQ(float128(0.0),
LIBC_NAMESPACE::shared::modff128(float128(0.0), &modff128_iptr));
EXPECT_FP_EQ(float128(0.0), modff128_iptr);
- EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::remainderf128(
- float128(1.0), float128(1.0)));
int remquof128_exp = 0;
EXPECT_FP_EQ(float128(0.0),
LIBC_NAMESPACE::shared::remquof128(float128(1.0), float128(1.0),
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index e3933e228e8e5..684d68f7af811 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -6800,8 +6800,8 @@ libc_support_library(
hdrs = ["src/__support/math/remainderf128.h"],
deps = [
":__support_fputil_division_and_remainder_operations",
+ ":__support_fputil_float128",
":__support_macros_config",
- ":llvm_libc_types_float128",
],
)
@@ -13179,6 +13179,8 @@ libc_math_function(
libc_math_function(
name = "remainderf128",
additional_deps = [
+ ":__support_cpp_bit",
+ ":__support_fputil_float128",
":__support_math_remainderf128",
],
)
>From c0da237d101cb9d794a87699d0d3cf020c5ba644 Mon Sep 17 00:00:00 2001
From: Sukumarsawant <sawantsukumar at gmail.com>
Date: Thu, 20 Aug 2026 16:24:00 +0530
Subject: [PATCH 3/3] nit + bf16 fix
---
libc/test/shared/shared_math_constexpr_test.cpp | 17 +++++++++++------
libc/test/shared/shared_math_test.cpp | 14 ++++++++++----
2 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp
index 49e899fda6943..f1407df7a39f1 100644
--- a/libc/test/shared/shared_math_constexpr_test.cpp
+++ b/libc/test/shared/shared_math_constexpr_test.cpp
@@ -381,11 +381,6 @@ static_assert(0 == LIBC_NAMESPACE::shared::isnanl(0.0L));
//===----------------------------------------------------------------------===//
static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
-static_assert(float128(0.0) ==
- LIBC_NAMESPACE::shared::remainderf128(Float128(1.0),
- Float128(1.0)));
-static_assert(0 ==
- LIBC_NAMESPACE::shared::fmodf128(Float128(4.0), Float128(2.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::copysignf128(Float128(0.0),
Float128(0.0)));
@@ -423,6 +418,8 @@ static_assert(Float128(0.0) ==
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::fminimum_numf128(Float128(0.0),
Float128(0.0)));
+static_assert(Float128(0.0) ==
+ LIBC_NAMESPACE::shared::fmodf128(Float128(4.0), Float128(2.0)));
static_assert(0LL == LIBC_NAMESPACE::shared::llrintf128(Float128(0.0)));
static_assert(0LL == LIBC_NAMESPACE::shared::llroundf128(Float128(0.0)));
static_assert(0L == LIBC_NAMESPACE::shared::lrintf128(Float128(0.0)));
@@ -435,6 +432,9 @@ static_assert(Float128(0.0) ==
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::nextafterf128(Float128(0.0),
Float128(0.0)));
+static_assert(Float128(0.0) ==
+ LIBC_NAMESPACE::shared::remainderf128(Float128(1.0),
+ Float128(1.0)));
static_assert(Float128(0.0) ==
LIBC_NAMESPACE::shared::roundf128(Float128(0.0)));
static_assert(Float128(0.0) ==
@@ -482,10 +482,15 @@ constexpr float128 TOTALORDERMAGF128_Y = float128(0.0);
static_assert(1 ==
LIBC_NAMESPACE::shared::totalordermagf128(&TOTALORDERMAGF128_X,
&TOTALORDERMAGF128_Y));
+static_assert(float128(0.0) ==
+ LIBC_NAMESPACE::shared::fmodf128(float128(4.0), float128(2.0)));
static_assert(float128(0.0) == [] {
float128 iptr{};
return LIBC_NAMESPACE::shared::modff128(float128(0.0), &iptr);
}());
+static_assert(float128(0.0) ==
+ LIBC_NAMESPACE::shared::remainderf128(float128(1.0),
+ float128(1.0)));
static_assert(float128(0.0) == [] {
int exp{};
return LIBC_NAMESPACE::shared::remquof128(float128(1.0), float128(1.0), &exp);
@@ -587,7 +592,7 @@ constexpr bfloat16 TOTALORDERMAGBF16_Y = bfloat16(0.0);
static_assert(1 ==
LIBC_NAMESPACE::shared::totalordermagbf16(&TOTALORDERMAGBF16_X,
&TOTALORDERMAGBF16_Y));
-static_assert(0 ==
+static_assert(bfloat16(0.0) ==
LIBC_NAMESPACE::shared::fmodbf16(bfloat16(4.0), bfloat16(2.0)));
static_assert(bfloat16(0.0) == [] {
bfloat16 iptr{};
diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp
index 1eccd4a1ea585..1d7d9d1d3cae1 100644
--- a/libc/test/shared/shared_math_test.cpp
+++ b/libc/test/shared/shared_math_test.cpp
@@ -587,9 +587,6 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::atan2f128(Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::ceilf128(Float128(0.0)));
- EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::remainderf128(
- Float128(1.0), Float128(1.0)));
- LIBC_NAMESPACE::shared::fmodf128(Float128(1.0), Float128(1.0));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::copysignf128(
Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fabsf128(Float128(0.0)));
@@ -616,6 +613,8 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
Float128(0.0), Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128(
Float128(0.0), Float128(0.0)));
+ EXPECT_FP_EQ(Float128(0.0),
+ LIBC_NAMESPACE::shared::fmodf128(Float128(1.0), Float128(1.0)));
EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llrintf128(Float128(0.0)));
EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llroundf128(Float128(0.0)));
EXPECT_EQ(0L, LIBC_NAMESPACE::shared::lrintf128(Float128(0.0)));
@@ -627,6 +626,8 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) {
EXPECT_FP_EQ(neg_min_denormal,
LIBC_NAMESPACE::shared::nextdownf128(Float128(0.0)));
EXPECT_FP_EQ(min_denormal, LIBC_NAMESPACE::shared::nextupf128(Float128(0.0)));
+ EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::remainderf128(
+ Float128(1.0), Float128(1.0)));
EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::rintf128(Float128(0.0)));
EXPECT_FP_EQ(Float128(0.0),
LIBC_NAMESPACE::shared::roundevenf128(Float128(0.0)));
@@ -737,10 +738,14 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) {
float128 totalordermagf128_y = float128(0.0);
EXPECT_EQ(1, LIBC_NAMESPACE::shared::totalordermagf128(&totalordermagf128_x,
&totalordermagf128_y));
+ EXPECT_FP_EQ(float128(0.0),
+ LIBC_NAMESPACE::shared::fmodf128(float128(1.0), float128(1.0)));
float128 modff128_iptr = float128(0.0);
EXPECT_FP_EQ(float128(0.0),
LIBC_NAMESPACE::shared::modff128(float128(0.0), &modff128_iptr));
EXPECT_FP_EQ(float128(0.0), modff128_iptr);
+ EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::remainderf128(
+ float128(1.0), float128(1.0)));
int remquof128_exp = 0;
EXPECT_FP_EQ(float128(0.0),
LIBC_NAMESPACE::shared::remquof128(float128(1.0), float128(1.0),
@@ -867,7 +872,8 @@ TEST(LlvmLibcSharedMathTest, AllBFloat16) {
bfloat16 totalordermagbf16_y = bfloat16(0.0);
EXPECT_EQ(1, LIBC_NAMESPACE::shared::totalordermagbf16(&totalordermagbf16_x,
&totalordermagbf16_y));
- LIBC_NAMESPACE::shared::fmodbf16(bfloat16(1.0), bfloat16(1.0));
+ EXPECT_FP_EQ(bfloat16(0.0),
+ LIBC_NAMESPACE::shared::fmodbf16(bfloat16(1.0), bfloat16(1.0)));
bfloat16 modfbf16_iptr = bfloat16(0.0);
EXPECT_FP_EQ(bfloat16(0.0),
LIBC_NAMESPACE::shared::modfbf16(bfloat16(0.0), &modfbf16_iptr));
More information about the llvm-branch-commits
mailing list