[llvm-branch-commits] [clang] [libc] [llvm] [clang][docs] Adopt the furo theme used by llvm and libc (PR #214869)

[Reid Kleckner via llvm-branch-commits]

rnk wrote:

> https://clangdocs.staging.reidkleckner.dev/ looks to be a general nginx page, so I may be responding too late the see the previous (I was out for the eclipse last week, sorry!)

Eclipse, fun. :) Yeah, I started serving the content under /{before|after}/${proj}/docs/, so https://clangdocs.staging.reidkleckner.dev/after/clang/docs/ has the clang index.html, and https://clangdocs.staging.reidkleckner.dev/after/libc/docs/ has the libc HTML, to show that there are no regressions.

> My only worry is the copybutton stuff. I built that when doing the libc furo site because I wasn't sure how to get another sphinx module installed on the server. We might be better served with something like https://executablebooks.github.io/sphinx-copybutton/ instead of my little hack.
> 
> With this RFC, are we still allowed to innovate on our own sites if we have things that we'd like to try?

Certainly, yes, I think folks should feel free to experiment and do stuff. I think we can effectively pip install sphinx modules by adding stuff to llvm/docs/requirements.txt.in (and/or without .in, I'm not a pip expert), since that's how furo was installed, and it seems to have worked automatically. CI systems truly are remote execution as a service, so we could absolutely replace this custom copybutton with a standard one.

I just assumed that the first reviewer comment would be  to avoid mindless code duplication, so I went ahead and shared what we have.

https://github.com/llvm/llvm-project/pull/214869