[llvm-branch-commits] [clang] clang/AMDGPU: Don't emit target-features on AMDGCN-flavored SPIR-V (PR #216678)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 56104 tests passed
* 1509 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.CodeGen/link-builtin-bitcode.c</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -cc1 -internal-isystem C:\_work\llvm-project\llvm-project\build\lib\clang\24\include -nostdsysteminc -triple amdgpu8.03-- -DBITCODE -emit-llvm-bc -o C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp-lib.bc C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -cc1 -internal-isystem 'C:\_work\llvm-project\llvm-project\build\lib\clang\24\include' -nostdsysteminc -triple amdgpu8.03-- -DBITCODE -emit-llvm-bc -o 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp-lib.bc' 'C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c'
# note: command had no output on stdout or stderr
# RUN: at line 3
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -cc1 -internal-isystem C:\_work\llvm-project\llvm-project\build\lib\clang\24\include -nostdsysteminc -triple amdgpu-- -DBITCODE -emit-llvm-bc -o C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp-lib.no-cpu.bc C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -cc1 -internal-isystem 'C:\_work\llvm-project\llvm-project\build\lib\clang\24\include' -nostdsysteminc -triple amdgpu-- -DBITCODE -emit-llvm-bc -o 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp-lib.no-cpu.bc' 'C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c'
# note: command had no output on stdout or stderr
# RUN: at line 5
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -cc1 -internal-isystem C:\_work\llvm-project\llvm-project\build\lib\clang\24\include -nostdsysteminc -triple amdgpu9.0a-- -emit-llvm-bc -o C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp.bc C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -cc1 -internal-isystem 'C:\_work\llvm-project\llvm-project\build\lib\clang\24\include' -nostdsysteminc -triple amdgpu9.0a-- -emit-llvm-bc -o 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp.bc' 'C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c'
# note: command had no output on stdout or stderr
# RUN: at line 6
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -cc1 -internal-isystem C:\_work\llvm-project\llvm-project\build\lib\clang\24\include -nostdsysteminc -triple amdgpu9.0a-- -emit-llvm    -mlink-builtin-bitcode C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp-lib.bc -o - C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp.bc | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -cc1 -internal-isystem 'C:\_work\llvm-project\llvm-project\build\lib\clang\24\include' -nostdsysteminc -triple amdgpu9.0a-- -emit-llvm -mlink-builtin-bitcode 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp-lib.bc' -o - 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp.bc'
# .---command stderr------------
# | warning: Linking two modules of different target triples: 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp-lib.bc' is 'amdgpu8.03-unknown-unknown' whereas 'C:\_work\llvm-project\llvm-project\build\tools\clang\test\CodeGen\Output\link-builtin-bitcode.c.tmp.bc' is 'amdgpu9.0a-unknown-unknown'
# | 
# `-----------------------------
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c:47:11: error: CHECK: expected string not found in input
# | // CHECK: attributes #[[ATTR_COMPATIBLE]] = { {{.*}} "target-features"="+16-bit-insts,+atomic-buffer-global-pk-add-f16-insts,+atomic-fadd-rtn-insts,+atomic-fmin-fmax-global-f64,+ci-insts,+cube-insts,+cvt-pknorm-vop2-insts,+dl-insts,+dot1-insts,+dot10-insts,+dot2-insts,+dot3-insts,+dot4-insts,+dot5-insts,+dot6-insts,+dot7-insts,+dpp,+flat-global-insts,+gfx8-insts,+gfx9-insts,+gfx90a-insts,+gws,+image-insts,+lerp-inst,+mai-insts,+mqsad-insts,+mqsad-pk-insts,+msad-insts,+qsad-insts,+s-memrealtime,+s-memtime-inst,+sad-insts,+vmem-to-lds-load-insts,+wavefrontsize64" }
# |           ^
# | <stdin>:47:117: note: scanning from here
# | attributes #0 = { convergent noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" }
# |                                                                                                                     ^
# | <stdin>:47:117: note: with "ATTR_COMPATIBLE" equal to "1"
# | attributes #0 = { convergent noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" }
# |                                                                                                                     ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\clang\test\CodeGen\link-builtin-bitcode.c
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |             .
# |             .
# |             .
# |            42: define internal i32 @attr_incompatible() #3 { 
# |            43: entry: 
# |            44:  ret i32 42 
# |            45: } 
# |            46:  
# |            47: attributes #0 = { convergent noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" } 
# | check:47'0                                                                                                                        {   search range start (exclusive)
# | check:47'1                                                                                                                            error: no match found in search range
# | check:47'2                                                                                                                            with "ATTR_COMPATIBLE" equal to "1"
# |            48: attributes #1 = { convergent noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+16-bit-insts,+atomic-buffer-global-pk-add-f16-insts,+atomic-fadd-rtn-insts,+atomic-fmin-fmax-global-f64,+ci-insts,+cube-insts,+cvt-pknorm-vop2-insts,+dl-insts,+dot1-insts,+dot10-insts,+dot2-insts,+dot3-insts,+dot4-insts,+dot5-insts,+dot6-insts,+dot7-insts,+dpp,+fast-denormal-f32,+fast-fmaf,+flat-global-insts,+gfx8-insts,+gfx9-insts,+gfx90a-insts,+gws,+image-insts,+lerp-inst,+mai-insts,+mqsad-insts,+mqsad-pk-insts,+msad-insts,+qsad-insts,+s-memrealtime,+s-memtime-inst,+sad-insts,+vmem-to-lds-load-insts,+wavefrontsize64" } 
# |            49: attributes #2 = { convergent noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+16-bit-insts,+atomic-buffer-global-pk-add-f16-insts,+atomic-fadd-rtn-insts,+atomic-fmin-fmax-global-f64,+ci-insts,+cube-insts,+cvt-pknorm-vop2-insts,+dl-insts,+dot1-insts,+dot10-insts,+dot2-insts,+dot3-insts,+dot4-insts,+dot5-insts,+dot6-insts,+dot7-insts,+dot8-insts,+dpp,+fast-denormal-f32,+fast-fmaf,+flat-global-insts,+gfx8-insts,+gfx9-insts,+gfx90a-insts,+gws,+image-insts,+lerp-inst,+mai-insts,+mqsad-insts,+mqsad-pk-insts,+msad-insts,+qsad-insts,+s-memrealtime,+s-memtime-inst,+sad-insts,+vmem-to-lds-load-insts,+wavefrontsize64" } 
# |            50: attributes #3 = { convergent noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+16-bit-insts,+atomic-buffer-global-pk-add-f16-insts,+atomic-fadd-rtn-insts,+atomic-fmin-fmax-global-f64,+ci-insts,+cube-insts,+cvt-pknorm-vop2-insts,+dl-insts,+dot1-insts,+dot10-insts,+dot2-insts,+dot3-insts,+dot4-insts,+dot5-insts,+dot6-insts,+dot7-insts,+dpp,+fast-denormal-f32,+fast-fmaf,+flat-global-insts,+gfx8-insts,+gfx90a-insts,+gws,+image-insts,+lerp-inst,+mai-insts,+mqsad-insts,+mqsad-pk-insts,+msad-insts,+qsad-insts,+s-memrealtime,+s-memtime-inst,+sad-insts,+vmem-to-lds-load-insts,+wavefrontsize64,-gfx9-insts" } 
# |            51: attributes #4 = { convergent } 
# |            52:  
# |            53: !llvm.module.flags = !{!0} 
# |            54: !llvm.ident = !{!1} 
# |            55:  
# |            56: !0 = !{i32 1, !"amdhsa_code_object_version", i32 600} 
# |            57: !1 = !{!"clang version 24.0.0git (https://github.com/llvm/llvm-project 2f5c23e399ec7369f2242883c45b6539c7885231)"} 
# | check:47'3                                                                                                                        } search range end (exclusive)
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/216678