[llvm-branch-commits] [lld] release/22.x: [LLD][COFF] Fix out-of-bounds write when filling gaps with INT3 in code sections (#180411) (PR #198212)

[Maj Soklič via llvm-branch-commits]

maj113 wrote:

> Thanks for pointing this out - I missed this comment. I'm not entirely convinced that the issue is caused by this commit though. But perhaps that's reason enough to hold back off backporting it after all?

I Somehow missed the entire conversation after posting that.

If I still remember correctly, the issue is the fact that if file alignment is anything below the default 4096B, virtual size must always match raw size, and a virtual BSS cannot exist in the PE, as that is only allowed with said default alignment. It isn't this PR that caused the issue, but more like it uncovered it. In my fork, the fix was this: https://github.com/maj113/llvm-pe/commit/f14d7c18355fa0860353801fdb9a567ea4c8fdf4

https://github.com/llvm/llvm-project/pull/198212