[llvm-branch-commits] [Clang] Make NewPM switch respect shouldDefaultToNewPM (PR #214571)

[Aiden Grossman via llvm-branch-commits]

boomanaiden154 wrote:

> I'm probably missing something here, but we also have TargetOptions with somewhat similar settings. This redundancy was there from the start (https://reviews.llvm.org/D83608), but I couldn't find an explanation in the commit or the RFC. Why do we have both? It doesn't look like one will eventually subsume the other.

Yeah, looking at it more, we should probably do something about this. I was assuming that `CGPassBuilderOptions` was going to subsume `TargetOptions`, but it doesn't look like that.

I think I'm convinced that a common abstraction makes sense now. I'm going to land this to get stuff unblocked but will be working on building something (hopefully relatively simple) out before branching out to other frontends.

https://github.com/llvm/llvm-project/pull/214571