[llvm-branch-commits] [llvm] CodeGen: Synthesize "float-abi" module flag from -float-abi (PR #215795)

[Saleem Abdulrasool via llvm-branch-commits]

================
@@ -774,6 +776,14 @@ void codegen::setFunctionAttributes(Function &F, StringRef CPU,
 
 void codegen::setFunctionAttributes(Module &M, StringRef CPU,
                                     StringRef Features, StringRef TuneCPU) {
+  // Synthesize the "float-abi" module flag from the -float-abi option,
+  FloatABI::ABIType ABI = getFloatABIForCalls();
+  if (ABI != FloatABI::Default && !M.getModuleFlag("float-abi")) {
----------------
compnerd wrote:

This feels wrong - the command line option should override the module no? Or perhaps it should be a hard error saying that the two are in conflict.

https://github.com/llvm/llvm-project/pull/215795