[llvm-branch-commits] [mlir] [MLIR][LLVM] Preserve unknown function metadata on import (PR #203022)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRImport.dir/ModuleImport.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRImport.dir/ModuleImport.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\lib\Target\LLVMIR -IC:\_work\llvm-project\llvm-project\mlir\lib\Target\LLVMIR -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\mlir\lib\Target\LLVMIR\CMakeFiles\obj.MLIRTargetLLVMIRImport.dir\ModuleImport.cpp.obj /Fdtools\mlir\lib\Target\LLVMIR\CMakeFiles\obj.MLIRTargetLLVMIRImport.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Target\LLVMIR\ModuleImport.cpp
C:\_work\llvm-project\llvm-project\mlir\lib\Target\LLVMIR\ModuleImport.cpp(3302,59): error: too many arguments to function call, expected single argument 'md', have 4 arguments
3302 |       Attribute nodeAttr = convertMetadataToAttr(context, metadataNode, iface,
|                            ~~~~~~~~~~~~~~~~~~~~~          ^~~~~~~~~~~~~~~~~~~~
3303 |                                                  getNamelessGlobalSymbol);
|                                                  ~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\mlir\lib\Target\LLVMIR\ModuleImport.cpp(237,25): note: 'convertMetadataToAttr' declared here
237 | Attribute ModuleImport::convertMetadataToAttr(const llvm::Metadata *md) {
|                         ^                     ~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/203022