[llvm-branch-commits] [lldb] [lldb] Refactor RegisterTypeBuilder (PR #213897)

[Greg Clayton via llvm-branch-commits]

================
@@ -35,94 +33,117 @@ RegisterTypeBuilderClang::CreateInstance(Target &target) {
 RegisterTypeBuilderClang::RegisterTypeBuilderClang(Target &target)
     : m_target(target) {}
 
+static std::string MakeTypeName(const RegisterType &type_info,
+                                uint32_t register_byte_size) {
+  std::string type_name = "__lldb_register_fields_";
----------------
clayborg wrote:

should this be `"__lldb_register_type_"` instead of `fields`? Also, do we want make a namespace named `__lldb_register_type` instead of prepending this to the name? I see we are appending "flags_" and "enum_" below, so maybe this initial typename prefix should just be `"__lldb_register_"`?

https://github.com/llvm/llvm-project/pull/213897