[llvm-branch-commits] [lld] [PAC][lld] Do not emit AUTH relocs against undef weak non-preemptible symbols (PR #194636)

[Peter Smith via llvm-branch-commits]

================
@@ -793,9 +793,12 @@ static void addGotAuthEntry(Ctx &ctx, Symbol &sym) {
     return;
   }
 
-  // Signed GOT requires dynamic relocation.
-  ctx.in.relaDyn->addReloc(
-      {R_AARCH64_AUTH_RELATIVE, ctx.in.got.get(), off, false, sym, 0, R_ABS});
+  // Signed GOT requires dynamic relocation unless the symbol is
+  // non-preemptible and undefined weak.
----------------
smithp35 wrote:

Do we know that if `!sym.isUndefWeak()` then it is always non-preemtible? If yes could be worth mentioning in the comment as there's no explicit test that the symbol isn't preemptible.

https://github.com/llvm/llvm-project/pull/194636