[llvm-branch-commits] [OpenMP] Add sanity check for concurrent taskgraph reset (PR #195076)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Apr 30 05:55:42 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- openmp/runtime/src/kmp_tasking.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/openmp/runtime/src/kmp_tasking.cpp b/openmp/runtime/src/kmp_tasking.cpp
index 6d33ac1d1..36292a558 100644
--- a/openmp/runtime/src/kmp_tasking.cpp
+++ b/openmp/runtime/src/kmp_tasking.cpp
@@ -5940,8 +5940,9 @@ void __kmpc_taskgraph(ident_t *loc_ref, kmp_int32 gtid,
// already performing a record operation for this taskgraph/graph_id.
// That's likely a bug, so tell the user and assert.
if (old_status != KMP_TDG_READY) {
- KG_TRACE(1, ("*** Multiple threads attempting to re-record taskgraph concurrently: T#%d loc=%p taskgraph=%p graph_id=%d\n",
- gtid, loc_ref, header, graph_id));
+ KG_TRACE(1, ("*** Multiple threads attempting to re-record taskgraph "
+ "concurrently: T#%d loc=%p taskgraph=%p graph_id=%d\n",
+ gtid, loc_ref, header, graph_id));
KMP_DEBUG_ASSERT(old_status == KMP_TDG_READY);
}
// Move the existing record to the header's expiring list
``````````
</details>
https://github.com/llvm/llvm-project/pull/195076
More information about the llvm-branch-commits
mailing list