[llvm-branch-commits] [lldb] [lldb] Implement delayed breakpoints (PR #192971)

[Felipe de Azevedo Piovezan via llvm-branch-commits]

felipepiovezan wrote:

> The rationale for eager deletion is: if we're updating `m_breakpoint_site_list`, then perform the operation immediately. It isn't clear to me that we can always update the site list but delay the action, but I can try again

Ah, another thing that would potentially be dangerous: the destructor of BreakpointSite iterates over all constituents and clears the site. Can we delay this?
.... but also BreakpointLocation stores a shared pointer to the site. So if a `BreakpointSite` is being destructed, then it implies no BreakpointLocation contains that site. This feels wrong, it sounds like the destructor of BreakpointSite should be empty.

https://github.com/llvm/llvm-project/pull/192971