[llvm-branch-commits] [lldb] [lldbremote][NFC] Factor out code handling breakpoint packets (PR #192915)

[David Spickett via llvm-branch-commits]

================
@@ -2903,155 +2904,146 @@ GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo(
   return SendPacketNoLock(response.GetString());
 }
 
-GDBRemoteCommunication::PacketResult
-GDBRemoteCommunicationServerLLGS::Handle_Z(StringExtractorGDBRemote &packet) {
+namespace {
+struct UseBreakpoint {
+  bool want_hardware;
----------------
DavidSpickett wrote:

I know this becomes false anyway but just so it doesn't look weird compared to the one below put `= false;` here.

Why it's false - that bit I understand. Watchpoints must be hardware, code breakpoints we only use hardware if we have to or are told to.

https://github.com/llvm/llvm-project/pull/192915