[llvm-branch-commits] [lldb] [lldbremote][NFC] Factor out code handling breakpoint packets (PR #192915)

[Felipe de Azevedo Piovezan via llvm-branch-commits]

================
@@ -2900,155 +2900,172 @@ GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo(
   return SendPacketNoLock(response.GetString());
 }
 
-GDBRemoteCommunication::PacketResult
-GDBRemoteCommunicationServerLLGS::Handle_Z(StringExtractorGDBRemote &packet) {
+namespace {
+/// Helper struct to expand a GDBStoppointType into flags.
+struct BreakpointKind {
+  bool want_hardware;
+  bool want_breakpoint;
----------------
felipepiovezan wrote:

Based on the comments on this PR, we're all willing to be a bit more aggressive with the rewrites.... so let me use a `std::variant` here.

https://github.com/llvm/llvm-project/pull/192915