[llvm-branch-commits] [lldb] [lldbremote][NFC] Factor out code handling breakpoint packets (PR #192915)

[David Spickett via llvm-branch-commits]

================
@@ -2900,155 +2900,172 @@ GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo(
   return SendPacketNoLock(response.GetString());
 }
 
-GDBRemoteCommunication::PacketResult
-GDBRemoteCommunicationServerLLGS::Handle_Z(StringExtractorGDBRemote &packet) {
+namespace {
+/// Helper struct to expand a GDBStoppointType into flags.
+struct BreakpointKind {
+  bool want_hardware;
+  bool want_breakpoint;
----------------
DavidSpickett wrote:

Yeah it's a bit odd to have breakpoint kind and then say no, no breakpoint for me please :)

I guess it might mean "I want a code breakpoint rather than a data breakpoint (watchpoint)".

Edit: I see it does mean that, but I agree with leaving it as is for the time being.

There are two groups of people it seems, those who say "breakpoint" and mean code and data break points and those that say "breakpoint" in contrast with "watchpoint". Sometimes I am both I have to admit.

https://github.com/llvm/llvm-project/pull/192915