[llvm-branch-commits] [llvm] release/22.x: [NFC][AArch64] Allocate AArch64Subtarget on the heap instead of stack (#176488) (PR #193109)

[David Green via llvm-branch-commits]

davemgreen wrote:

> Dave can correct me if I'm misunderstanding but I'm pretty sure it means there's nothing incorrect or risky in this fix, it's just that the whole idea of us constructing additional AArch64Subtargets is a bit dodgy in the first place. That is already on LLVM 22, that is not introduced by this fix, so shouldn't prevent this fix from being merged.

Yes that exactly. This patch is better than what is on the branch, that is causing stack issues for people due to the size of the AArch64Subtarget. The change will be an NFC in terms of generated code, and has been on trunk without issue for quite a while (it only just missed the branch I believe).

https://github.com/llvm/llvm-project/pull/193109