[llvm-branch-commits] [llvm] [LSR] Preserve LCSSA in SCEVRewriter (PR #191665)

[Vikram Hegde via llvm-branch-commits]

vikramRH wrote:

Another case of critical edge splitting not preserving LCSSA, https://godbolt.org/z/nbKrWrKan (does get fixed by https://github.com/llvm/llvm-project/pull/192371 though ). However why not just set the "setPreserveLCSSA" in criticalEdgeSplitting options ? I think this should render the current fixup via "InsertedNonLCSSAInsts" redundant and we already update the user instructions for remaining Fixups which may have been obscured by the newly created blocks.

https://github.com/llvm/llvm-project/pull/191665