[llvm-branch-commits] [llvm] IR: Introduce !elf_section_properties for setting section properties. (PR #149260)

[Peter Collingbourne via llvm-branch-commits]

pcc wrote:

> Note: The base branch is not main.

Correct. There are no more dependencies for this change, but I think spr doesn't set the base branch to main after dependencies have landed.

> When two globals specify the same explicit section but with different sectin properties, what's the suggested behavior?

I would expect two sections like in your example. I added a test for that.

> @efriedma-quic raised optimizer-interaction concerns that have been partly addressed (ConstantMerge was already safe, GlobalMerge was fixed in the follow-up #175875).

I think they have been addressed. Optimization passes that merge globals without checking for metadata, like GlobalMerge used to do, are buggy, as they violate the existing metadata rules, and should be fixed (in a followup if necessary). I'm not aware of any remaining buggy passes.

https://github.com/llvm/llvm-project/pull/149260