[llvm-branch-commits] [lldb] [lldb] Add extended variable support to Get*VariableList. (PR #181501)

[Med Ismail Bennani via llvm-branch-commits]

https://github.com/medismailben commented:

On paper this looks fine to me however there are 2 things that annoy me:
1. not to bike shed about names but I'm not a big fan of "extended variables" because it sounds like we're augmenting an existing variable but actually in this case, you're making one from scratch. I think "synthetic variables" would make more sense here, and we're already using it for SyntheticFrames and SyntheticFrameProviders.
2. Until then we didn't have to do any composition on the ValueType enum but that's not true anymore. Ideally I'd turn the `ValueType` enum  into a struct and add some helper functions to get the value type without the extended mask, but that would be quite an intrusive change. We could still make a standalone function (like we do for `StateIsRunningState` for the `StateType` enum) to wrap and unwrap the ValueType from the extended mask.

https://github.com/llvm/llvm-project/pull/181501