[llvm-branch-commits] [clang] [llvm] [mlir] [OMPIRBuilder] Add support for explicit deallocation points (PR #154752)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 61505 tests passed
* 1575 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] unittests/Frontend/CMakeFiles/LLVMFrontendTests.dir/OpenMPIRBuilderTest.cpp.obj</summary>

```
FAILED: [code=1] unittests/Frontend/CMakeFiles/LLVMFrontendTests.dir/OpenMPIRBuilderTest.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\unittests\Frontend -IC:\_work\llvm-project\llvm-project\llvm\unittests\Frontend -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG -Wno-gnu-zero-variadic-macro-arguments /EHs-c- /GR- -Wno-suggest-override /showIncludes /Founittests\Frontend\CMakeFiles\LLVMFrontendTests.dir\OpenMPIRBuilderTest.cpp.obj /Fdunittests\Frontend\CMakeFiles\LLVMFrontendTests.dir\ -c -- C:\_work\llvm-project\llvm-project\llvm\unittests\Frontend\OpenMPIRBuilderTest.cpp
C:\_work\llvm-project\llvm-project\llvm\unittests\Frontend\OpenMPIRBuilderTest.cpp(7302,31): error: no viable conversion from 'llvm::OpenMPIRBuilder::TargetDataInfo' to 'ArrayRef<BasicBlock *>'
7302 |                               Info, EntryInfo, DefaultAttrs, RuntimeAttrs,
|                               ^~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/ArrayRef.h(40,40): note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'llvm::OpenMPIRBuilder::TargetDataInfo' to 'const ArrayRef<llvm::BasicBlock *> &' for 1st argument
40 |   class LLVM_GSL_POINTER [[nodiscard]] ArrayRef {
|                                        ^~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/ArrayRef.h(40,40): note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'llvm::OpenMPIRBuilder::TargetDataInfo' to 'ArrayRef<llvm::BasicBlock *> &&' for 1st argument
40 |   class LLVM_GSL_POINTER [[nodiscard]] ArrayRef {
|                                        ^~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/ArrayRef.h(69,18): note: candidate constructor not viable: no known conversion from 'llvm::OpenMPIRBuilder::TargetDataInfo' to 'llvm::BasicBlock *const &' for 1st argument
69 |     /*implicit*/ ArrayRef(const T &OneElt LLVM_LIFETIME_BOUND)
|                  ^        ~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/ArrayRef.h(110,28): note: candidate constructor not viable: no known conversion from 'llvm::OpenMPIRBuilder::TargetDataInfo' to 'std::initializer_list<llvm::BasicBlock *>' for 1st argument
110 |     constexpr /*implicit*/ ArrayRef(
|                            ^
111 |         std::initializer_list<T> Vec LLVM_LIFETIME_BOUND)
|         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/ArrayRef.h(94,28): note: candidate template ignored: substitution failure [with C = llvm::OpenMPIRBuilder::TargetDataInfo]: no member named 'data' in 'llvm::OpenMPIRBuilder::TargetDataInfo'
90 |                     decltype(std::declval<const C &>().data()) *,
|                                                        ~~~~
91 |                     const T *const *>,
92 |                 std::is_integral<decltype(std::declval<const C &>().size())>>,
93 |             void>>
94 |     /*implicit*/ constexpr ArrayRef(const C &V)
|                            ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/ArrayRef.h(99,28): note: candidate template ignored: could not match 'llvm::BasicBlock *[N]' against 'llvm::OpenMPIRBuilder::TargetDataInfo'
99 |     /*implicit*/ constexpr ArrayRef(const T (&Arr LLVM_LIFETIME_BOUND)[N])
|                            ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/ArrayRef.h(123,5): note: candidate template ignored: could not match 'iterator_range<U *>' against 'llvm::OpenMPIRBuilder::TargetDataInfo'
123 |     ArrayRef(const iterator_range<U *> &Range)
|     ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/Frontend/OpenMP/OMPIRBuilder.h(3611,30): note: passing argument to parameter 'DeallocBlocks' here
3611 |       ArrayRef<BasicBlock *> DeallocBlocks, TargetDataInfo &Info,
|                              ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/154752