[llvm-branch-commits] [llvm] [LoopUnroll] Fix freqs for unconditional latches: introduce tests (PR #191008)

[Joel E. Denny via llvm-branch-commits]

jdenny-ornl wrote:

> lgtm;

Thanks for the review.

> can't we use UTC?

Please advise if my understanding of UTC is lacking, but here is why I did not use it based on my prior experience with UTC-based tests:

- UTC generates a large set of FileCheck directives that often check   far more than a test needs to check.  While each of the tests in this patch has many RUN lines, each RUN line has its own small set of FileCheck directives that focus precisely on what the test is trying to check.
- UTC does not preserve comments among FileCheck directives.  I find comments critical in clarifying the various cases these tests are trying to check.

For both reasons, I fear that switching to UTC would make these tests substantially harder to understand and correctly maintain.

https://github.com/llvm/llvm-project/pull/191008