[llvm-branch-commits] [clang] [SSAF][UnsafeBufferUsage] Implement AST visitor that respects the contribution model (PR #188652)

[Balázs Benics via llvm-branch-commits]

https://github.com/steakhal commented:

I'd encourage thinking about splitting the PR in two ways.
Currently the PR summary suggests that it has a functional aspect (aka. change) besides just moving code around.

I think as a reviewer, I could be a lot more relaxed reviewing a PR if it was only [NFC](https://llvm.org/docs/Lexicon.html#n).
The NFC split would also make me view the change differently, and I wouldn't propose llvm-idiomatic suggestions, renames, or restructuring of the code - because would would preserve the shape of the code and just move things around.
While right now, I may spend my time on undesired and unactionable comments while doing the review.

Then the other half of the current change could get the deserved deep review.

Anyway, I left some inline comments that I've found.

https://github.com/llvm/llvm-project/pull/188652