[llvm-branch-commits] [llvm] release/22.x: [TargetLowering] Speculative fix for a non-determinism issue between different compilers. (#190219) (PR #190624)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Apr 6 09:12:04 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-selectiondag
Author: llvmbot
<details>
<summary>Changes</summary>
Backport e2e5db840109e9a5d5bb190fcae350161a6e5481
Requested by: @<!-- -->topperc
---
Full diff: https://github.com/llvm/llvm-project/pull/190624.diff
1 Files Affected:
- (modified) llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp (+3-3)
``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
index ee489f9fc74f9..b218b91c19cbb 100644
--- a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
@@ -11239,10 +11239,10 @@ void TargetLowering::forceExpandMultiply(SelectionDAG &DAG, const SDLoc &dl,
// If HiLHS and HiRHS are set, multiply them by the opposite low part and add
// the products to Hi.
if (HiLHS) {
+ SDValue RHLL = DAG.getNode(ISD::MUL, dl, VT, HiRHS, LHS);
+ SDValue RLLH = DAG.getNode(ISD::MUL, dl, VT, RHS, HiLHS);
Hi = DAG.getNode(ISD::ADD, dl, VT, Hi,
- DAG.getNode(ISD::ADD, dl, VT,
- DAG.getNode(ISD::MUL, dl, VT, HiRHS, LHS),
- DAG.getNode(ISD::MUL, dl, VT, RHS, HiLHS)));
+ DAG.getNode(ISD::ADD, dl, VT, RHLL, RLLH));
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/190624
More information about the llvm-branch-commits
mailing list