[llvm-branch-commits] [clang-tools-extra] [clang-doc] Refactor FriendInfo parameters to use ArrayRef (PR #190047)

[Paul Kirth via llvm-branch-commits]

================
@@ -957,6 +950,51 @@ llvm::Error ClangDocBitcodeReader::readBlock(unsigned ID, T I) {
   }
 }
 
+template <>
----------------
ilovepi wrote:

yeah. the way these are implemented requires a lot of repetition. Its kind of the story for everything in clang-doc (or at least the legacy APIs).

I looked at squashing back earlier in the history and ... I gave up. It was a huge pain to make the rebasing work. I think its easier to follow these,  since they're very straight forward,  and then verify that the right pattern and callbacks get used later in the refactor. I wish I had thought of this as I was going, but its been hard keeping the stack working under ASan and trying to make the history not terrible.

I've actually rewritten all the patches a few times now as the first incarnation actually didn't get run under sanitizers until the end. by then it wasn't just a matter of rebasing. I basically had to rewrite it all over again, being careful not to leak data. I spent a lot of time this round trying to clean things up and refactor once I came around to a useful pattern, but I didn't see it until pretty late in the series.

https://github.com/llvm/llvm-project/pull/190047